From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 1/11] Add generic helpers for arch IPI function calls Date: Fri, 25 Apr 2008 09:18:24 +0200 Message-ID: <20080425071823.GF12774@kernel.dk> References: <1208890227-24808-1-git-send-email-jens.axboe@oracle.com> <1208890227-24808-2-git-send-email-jens.axboe@oracle.com> <20080424220157.GA26179@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20080424220157.GA26179-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org> Sender: linux-arch-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, npiggin-l3A5Bk7waGM@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org On Thu, Apr 24 2008, Russell King wrote: > On Tue, Apr 22, 2008 at 08:50:17PM +0200, Jens Axboe wrote: > > + data->csd.func(data->csd.info); > > + > > + spin_lock(&data->lock); > > + cpu_clear(cpu, data->cpumask); > > + WARN_ON(data->refs == 0); > > + data->refs--; > > + refs = data->refs; > > Probably a silly question, but what does data->refs do that > cpus_empty(data->cpumask) wouldn't do? (as indeed ARM presently does.) I guess it can be marginally slower for NR_CPUS > BITS_PER_LONG, otherwise there's absolutely no reason to have a seperate ref counter. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from brick.kernel.dk ([87.55.233.238]:26638 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571AbYDYHS3 (ORCPT ); Fri, 25 Apr 2008 03:18:29 -0400 Date: Fri, 25 Apr 2008 09:18:24 +0200 From: Jens Axboe Subject: Re: [PATCH 1/11] Add generic helpers for arch IPI function calls Message-ID: <20080425071823.GF12774@kernel.dk> References: <1208890227-24808-1-git-send-email-jens.axboe@oracle.com> <1208890227-24808-2-git-send-email-jens.axboe@oracle.com> <20080424220157.GA26179@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080424220157.GA26179@flint.arm.linux.org.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, npiggin@suse.de, torvalds@linux-foundation.org, peterz@infradead.org, sam@ravnborg.org Message-ID: <20080425071824.pr9o2Wfcyx5TiePSwxPKGqFtAhI4ijkTYvdATJEmY8U@z> On Thu, Apr 24 2008, Russell King wrote: > On Tue, Apr 22, 2008 at 08:50:17PM +0200, Jens Axboe wrote: > > + data->csd.func(data->csd.info); > > + > > + spin_lock(&data->lock); > > + cpu_clear(cpu, data->cpumask); > > + WARN_ON(data->refs == 0); > > + data->refs--; > > + refs = data->refs; > > Probably a silly question, but what does data->refs do that > cpus_empty(data->cpumask) wouldn't do? (as indeed ARM presently does.) I guess it can be marginally slower for NR_CPUS > BITS_PER_LONG, otherwise there's absolutely no reason to have a seperate ref counter. -- Jens Axboe