From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] prepare kconfig inline optimization for all architectures Date: Sun, 27 Apr 2008 13:57:54 -0400 Message-ID: <20080427175754.GA28483@infradead.org> References: <20080427105100.GA14795@uranus.ravnborg.org> <20080427113158.GY2252@cs181133002.pp.htv.fi> <20080427172235.GA2252@cs181133002.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: Linus Torvalds Cc: Adrian Bunk , Sam Ravnborg , linux arch , LKML , Ingo Molnar , David Miller On Sun, Apr 27, 2008 at 10:32:28AM -0700, Linus Torvalds wrote: > Modern versions of gcc may do the right thing. Note the two very important > code-words: "modern" and "may". It's even worse than that, that may not even get it right. That's why we need always_inline to force it when we know we need it. Now for the cases where we don't know know that we either need or really really strongly want it we should just not mark it inline at all. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([18.85.46.34]:43528 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755743AbYD0R6E (ORCPT ); Sun, 27 Apr 2008 13:58:04 -0400 Date: Sun, 27 Apr 2008 13:57:54 -0400 From: Christoph Hellwig Subject: Re: [PATCH] prepare kconfig inline optimization for all architectures Message-ID: <20080427175754.GA28483@infradead.org> References: <20080427105100.GA14795@uranus.ravnborg.org> <20080427113158.GY2252@cs181133002.pp.htv.fi> <20080427172235.GA2252@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: Adrian Bunk , Sam Ravnborg , linux arch , LKML , Ingo Molnar , David Miller Message-ID: <20080427175754.Mc8xgKX0jaGk0-jjqZKnYULx80CBR2-3xOhvoFTfVAs@z> On Sun, Apr 27, 2008 at 10:32:28AM -0700, Linus Torvalds wrote: > Modern versions of gcc may do the right thing. Note the two very important > code-words: "modern" and "may". It's even worse than that, that may not even get it right. That's why we need always_inline to force it when we know we need it. Now for the cases where we don't know know that we either need or really really strongly want it we should just not mark it inline at all.