Re: [PATCH] prepare kconfig inline optimization for all architectures

Christoph Hellwig
2008-04-27T18:36:41Z

On Sun, Apr 27, 2008 at 08:31:31PM +0200, Sam Ravnborg wrote:
> The tendency is that gcc inline *more than we whish* - not less.
> Which is why we have noinline - to cover the cases where we do not
> want stuff inlined.

Which is exactly the wrong way around. noinline should be the default.
But that's probaby no fixable without touching gcc or doing ugly hacks
as in xfs.

> What the patch in question does is to make a difference
> between always_inle and inline.
> Previously they were the same. With the patch applied and
> with a gcc > 4.0 inline is now a hint.
>
> Did you actually read the patch?

Yes. As as I said I think having them the same, or rather only
having one of them makes more sense than having a hint in addition to
force.

> If you read the patch you will see that the architectures that
> want to enable this has to do an explicit HAVE_CC_INLINE_HINT
> so powerpc is not impacted by this until they request it.
> Exactly the reason why this was not widely enabled in the
> first place (but implemnted in a too x86 specific way).

Yes, and that part of your patch is a good thing, and makes it at
least sensible unlike ingos. The patch in this mail is the one
we should probably go for short term, although the right way to
sort it out is the long one, aka goign through all users of inline
and deciding what they really want.