Re: [PATCH] prepare kconfig inline optimization for all architectures

Arjan van de Ven
2008-04-27T23:26:06Z

On Sun, 27 Apr 2008 11:24:28 -0700 (PDT)
Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:

>
>
> On Sun, 27 Apr 2008, Christoph Hellwig wrote:
> >
> > As Linus mentioned the hint doesn't make any sense because gcc will
> > get it wrong anyway. In fact when you look at kernel code it tends
> > to inline the everything and the kitchensink as long as there's just
> > one caller and this bloat the stack but doesn't inline where it
> > needs to. Better don't try to mess with that and do it explicit.
>
> The thing is, the "inline" vs "always_inline" thing _could_ make
> sense, but sadly doesn't much.
>
> Part of it is that gcc imnsho inlines too aggressively anyway in the
> absense of "inline",

yup.. but this patch doesn't change that... the "no inline keyword" case
is totally unaffected...

(actually, other than some obscure commandline options, the only sane way to
avoid gcc doing this too agressive is using -Os)

--
If you want to reach me at my work email, use arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org
For development, discussion and tips for power savings,
visit http://www.lesswatts.org