public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: paulus@samba.org
Cc: linux-arch@vger.kernel.org, roland@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH] Change long to unsigned long in ptrace functions to fix sparse warnings
Date: Thu, 01 May 2008 16:16:08 -0700 (PDT)	[thread overview]
Message-ID: <20080501.161608.150609265.davem@davemloft.net> (raw)
In-Reply-To: <18458.19939.138289.173048@cargo.ozlabs.ibm.com>

From: Paul Mackerras <paulus@samba.org>
Date: Fri, 2 May 2008 09:10:27 +1000

> Sparse warns every time we have an (unsigned long __user *) cast on a
> long (not unsigned long) variable.  This happens frequently in the
> ptrace code because the addr and data arguments to sys_ptrace,
> ptrace_request, arch_ptrace et al. are long rather than unsigned long.
> 
> There doesn't seem to be any good reason not to have them be unsigned,
> so this changes them from long to unsigned long.
> 
> Signed-off-by: Paul Mackerras <paulus@samba.org>

Thanks for fixing this:

Acked-by: David S. Miller <davem@davemloft.net>

I thought there might be some cases that cared about
negative values of 'addr', but I can't see any.

  reply	other threads:[~2008-05-01 23:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01 23:10 [PATCH] Change long to unsigned long in ptrace functions to fix sparse warnings Paul Mackerras
2008-05-01 23:16 ` David Miller [this message]
2008-05-01 23:19   ` Roland McGrath
2008-05-01 23:20     ` Roland McGrath
2008-05-01 23:52     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080501.161608.150609265.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox