From: Arnd Bergmann <arnd@arndb.de>
To: monstr@seznam.cz
Cc: paulus@samba.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, Michal Simek <monstr@monstr.eu>
Subject: Re: [PATCH 1/1] DEBUGFS: Fixing name for debug fs
Date: Sat, 3 May 2008 23:07:03 +0200 [thread overview]
Message-ID: <200805032307.04352.arnd@arndb.de> (raw)
In-Reply-To: <c65b09261996cf3500b6faee201e2dd6c152973e.1209825194.git.monstr@monstr.eu>
On Saturday 03 May 2008, monstr@seznam.cz wrote:
> From: Michal Simek <monstr@monstr.eu>
>
> This change is made because powerpc_debugfs_root is arch
> specific name.
...
>
> static int powerpc_debugfs_init(void)
> {
> - powerpc_debugfs_root = debugfs_create_dir("powerpc", NULL);
> + debugfs_root = debugfs_create_dir("powerpc", NULL);
>
You left the name as "powerpc", which sort of defeats the purpose of your
patch. Files in debugfs are by definition not part of the ABI, so it's
actually possible to change this as well. How about making this "of"
instead of "powerpc"?
Arnd <><
next prev parent reply other threads:[~2008-05-03 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 14:35 FIXING names for debugfs monstr
2008-05-03 14:35 ` [PATCH 1/1] DEBUGFS: Fixing name for debug fs monstr
2008-05-03 21:07 ` Arnd Bergmann [this message]
2008-05-04 8:28 ` Michal Simek
2008-05-05 14:27 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805032307.04352.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=monstr@seznam.cz \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox