Re: [RFC][PATCH] sched_clock_cpu()

[Dhaval Giani <dhaval@linux.vnet.ibm.com>]

On Sat, May 03, 2008 at 09:26:07PM -0700, David Miller wrote:
> From: Ingo Molnar <mingo@elte.hu>
> Date: Sat, 3 May 2008 19:01:30 +0200
> 
> > 
> > * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> > 
> > > it _DOESN'T_ boot ;-/ and I seem to have caught a flu that makes my
> > > whole body hurt like hell, so I'm not getting anything done.
> > 
> > i think i see where your boot problem comes from:
> > 
> > > +struct sched_clock_data {
> > > +	spinlock_t lock;
> > 
> > that wont work very well when sched_clock() is called from within 
> > CONFIG_LOCK_STAT instrumentation. Does the patch below solve the boot 
> > problems for you?
> 
> Also, no platform can set HAVE_STABLE_CLOCK until we instantiate it in
> a Kconfig somewhere.  I've choosen to do it in kernel/Kconfig.hz and
> here are the sparc/sparc64 bits as well, I've booted this up with
> Peter's patch on my 64-cpu niagara2 box and done some basic testing.
> 
> It would be nice if a powerpc person could test the trivial
> powerpc Kconfig patch.
> 

On it. Let me get hold of a powerpc box here, and try it out.
-- 
regards,
Dhaval