From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: a.p.zijlstra@chello.nl, tglx@linutronix.de, guichaz@gmail.com,
andi@firstfloor.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, efault@gmx.de,
dhaval@linux.vnet.ibm.com
Subject: Re: [RFC][PATCH] sched_clock_cpu()
Date: Sun, 4 May 2008 11:00:25 +0200 [thread overview]
Message-ID: <20080504090024.GA29318@elte.hu> (raw)
In-Reply-To: <20080503.212607.157994166.davem@davemloft.net>
* David Miller <davem@davemloft.net> wrote:
> > that wont work very well when sched_clock() is called from within
> > CONFIG_LOCK_STAT instrumentation. Does the patch below solve the
> > boot problems for you?
>
> Also, no platform can set HAVE_STABLE_CLOCK until we instantiate it in
> a Kconfig somewhere. I've choosen to do it in kernel/Kconfig.hz and
> here are the sparc/sparc64 bits as well, I've booted this up with
> Peter's patch on my 64-cpu niagara2 box and done some basic testing.
applied, thanks David.
right now this topic looks good in review and in testing but it is
stalled on a bug: in overnight testing it triggered an ftrace self-test
hang that i bisected down to that patch. While that doesnt affect
mainline it's something that shows that the new sched_clock() code is
not as widely usable as the old code - have to investigate that some
more.
> It would be nice if a powerpc person could test the trivial powerpc
> Kconfig patch.
>
> Possibly this should be HAVE_UNSTABLE_CLOCK, then only one platform
> needs to set it :-)
heh, indeed :)
Initially i thought that it's better to first be safe, but this really
will only affect x86 in practice, so ... i think we'll switch around the
flag, turning this into a no-effort thing for everything but x86.
Ingo
next prev parent reply other threads:[~2008-05-04 9:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 16:29 [RFC][PATCH] sched_clock_cpu() Peter Zijlstra
2008-05-03 16:29 ` Peter Zijlstra
2008-05-03 16:37 ` Ingo Molnar
2008-05-03 16:37 ` Ingo Molnar
2008-05-03 16:55 ` Ingo Molnar
2008-05-03 17:30 ` Dhaval Giani
2008-05-03 17:30 ` Dhaval Giani
2008-05-04 4:16 ` David Miller
2008-05-04 4:30 ` Dhaval Giani
2008-05-04 4:38 ` Dhaval Giani
2008-05-04 4:38 ` Dhaval Giani
2008-05-03 17:01 ` Ingo Molnar
2008-05-04 4:26 ` David Miller
2008-05-04 5:09 ` Dhaval Giani
2008-05-04 9:00 ` Ingo Molnar [this message]
2008-05-05 11:32 ` Ingo Molnar
2008-05-05 21:47 ` Tony Breeds
2008-05-05 21:47 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080504090024.GA29318@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=dhaval@linux.vnet.ibm.com \
--cc=efault@gmx.de \
--cc=guichaz@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox