From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Stephen Neuendorffer" Subject: RE: [PATCH 07/56] microblaze_v2: Signal support Date: Mon, 5 May 2008 17:13:42 -0700 Message-ID: <20080506001339.619971A58057@mail55-wa4.bigfish.com> References: <9a7c6646e5dd9724c1cf34767adec181481fa3ef.1209897266.git.monstr@monstr.eu> <20080505213244.8DC757A0084@mail70-wa4.bigfish.com> <1210030436.5798.148.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 8BIT Return-path: Received: from outbound-wa4.frontbridge.com ([216.32.181.16]:63638 "EHLO outbound3-wa4-R.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755966AbYEFAPm convert rfc822-to-8bit (ORCPT ); Mon, 5 May 2008 20:15:42 -0400 Content-class: urn:content-classes:message In-reply-to: <1210030436.5798.148.camel@localhost> Sender: linux-arch-owner@vger.kernel.org List-ID: To: John Williams Cc: monstr@seznam.cz, linux-kernel@vger.kernel.org, arnd@arndb.de, linux-arch@vger.kernel.org, John Linn , matthew@wil.cx, will.newton@gmail.com, drepper@redhat.com, microblaze-uclinux@itee.uq.edu.au, grant.likely@secretlab.ca, Michal Simek I'm somewhat ignorant about what this code is attempting to do, but with some quick poking around (m68knommu, blackfin) seems to suggest that other architectures don't do this, while others (v850) have almost exactly the same code (although they are somewhat smarter and are careful not to flush the whole cache). At the very least, it seems like there is some work in this area needed. Steve > -----Original Message----- > From: John Williams [mailto:john.williams@petalogix.com] > Sent: Monday, May 05, 2008 4:34 PM > To: Stephen Neuendorffer > Cc: monstr@seznam.cz; linux-kernel@vger.kernel.org; arnd@arndb.de; linux-arch@vger.kernel.org; John > Linn; matthew@wil.cx; will.newton@gmail.com; drepper@redhat.com; microblaze-uclinux@itee.uq.edu.au; > grant.likely@secretlab.ca; Michal Simek > Subject: RE: [PATCH 07/56] microblaze_v2: Signal support > > On Mon, 2008-05-05 at 14:32 -0700, Stephen Neuendorffer wrote: > > (multiple places) can this code (and flush_cache_sigtramp()) go away? > > > > +#if 0 > > + flush_cache_sigtramp((unsigned long)frame->tramp); > > +#endif > > You have to icache_invalidate the sigtramp because you are writing into > memory that will shortly be executed. > > I'm not sure why this is #if'd away in the first place? > > John > >