From: "Stephen Neuendorffer" <stephen.neuendorffer@xilinx.com>
To: John Williams <john.williams@petalogix.com>
Cc: arnd@arndb.de, linux-arch@vger.kernel.org,
John Linn <linnj@xilinx.com>,
matthew@wil.cx, will.newton@gmail.com, drepper@redhat.com,
microblaze-uclinux@itee.uq.edu.au, grant.likely@secretlab.ca,
Michal Simek <monstr@monstr.eu>,
linux-kernel@vger.kernel.org
Subject: RE: [PATCH] Microblaze: implement dma-coherent API andrefactorcache flush code.
Date: Mon, 5 May 2008 17:31:07 -0700 [thread overview]
Message-ID: <20080506003104.4717D19B8050@mail213-sin.bigfish.com> (raw)
In-Reply-To: <1210032899.5798.179.camel@localhost>
> -----Original Message-----
> From: John Williams [mailto:john.williams@petalogix.com]
> Sent: Monday, May 05, 2008 5:15 PM
> To: Stephen Neuendorffer
> Cc: arnd@arndb.de; linux-arch@vger.kernel.org; John Linn;
matthew@wil.cx; will.newton@gmail.com;
> drepper@redhat.com; microblaze-uclinux@itee.uq.edu.au;
grant.likely@secretlab.ca; Michal Simek;
> linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] Microblaze: implement dma-coherent API
andrefactorcache flush code.
>
>
> > > Does the DMA API insist upon the dma_cache_sync call to guarantee
> > > sensible results? If so, your implementation looks fine. If not,
> > then
> > > the results will clearly be bogus as there's nothing magical about
the
> > > memory being allocated in dma_alloc.
> >
> > Yes, in fact this is one of the keys to getting the lltemac driver
to
> > work right. see Documentation/DMA-API.txt
> >
> > > To that end, can it just call kmalloc(), and similarly kfree() for
> > > dma_free?
> >
> > My understanding is that on other architectures (x86, for instance)
> > 'dma' memory ensures other things, like it's accessible in PCI
memory
> > space. On microblaze, there's nothing really special about dma
memory,
> > but you get the API as a chunk.
>
> Sure - what I meant is can dma_alloc just call kmalloc to do it's
work?
I scanned through Linux Device Drivers, and it appears that calling
get_free_pages is:
1) more efficient than kmalloc for large allocations
2) allocates physically contiguous memory, which kmalloc doesn't
necessarily do if there's an mmu.
Steve
next prev parent reply other threads:[~2008-05-06 0:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 22:37 [PATCH] Microblaze: implement dma-coherent API and refactor cache flush code Stephen Neuendorffer
2008-05-05 22:37 ` Stephen Neuendorffer
2008-05-05 22:57 ` John Williams
2008-05-05 23:12 ` [PATCH] Microblaze: implement dma-coherent API and refactorcache " Stephen Neuendorffer
2008-05-06 0:14 ` John Williams
2008-05-06 0:31 ` Stephen Neuendorffer [this message]
2008-05-06 7:23 ` [PATCH] Microblaze: implement dma-coherent API andrefactorcache " Geert Uytterhoeven
2008-05-06 9:33 ` Michal Simek
2008-05-06 9:28 ` [PATCH] Microblaze: implement dma-coherent API and refactor cache " Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506003104.4717D19B8050@mail213-sin.bigfish.com \
--to=stephen.neuendorffer@xilinx.com \
--cc=arnd@arndb.de \
--cc=drepper@redhat.com \
--cc=grant.likely@secretlab.ca \
--cc=john.williams@petalogix.com \
--cc=linnj@xilinx.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox