Re: [patch 2/2] lockless get_user_pages

Nick Piggin
2008-05-27T02:57:27Z

On Tue, May 27, 2008 at 11:46:27AM +0900, KOSAKI Motohiro wrote:
> > Aw, nobody likes fast_gup? ;)
>
> Ah, I misunderstood your intention.
> I thought you disklike fast_gup..
>
> I don't dislike it :()

Heh, no I was joking. fast_gup is not such a good name, especially for
grep or a reader who doesn't know gup is for get_user_pages.

> > Technically get_user_pages_lockless is wrong: the implementation may
> > not be lockless so one cannot assume it will not take mmap sem and
> > ptls.
>
> agreed.
>
>
> > But I do like to make it clear that it is related to get_user_pages.
> > get_current_user_pages(), maybe? Hmm, that's harder to grep for
> > both then I guess. get_user_pages_current?
>
> Yeah, good name.

OK, I'll rename it.

Thanks,
Nick