Re: [patch 2/2] lockless get_user_pages

Nick Piggin
2008-05-27T02:28:05Z

On Tue, May 27, 2008 at 09:57:11AM +0900, KOSAKI Motohiro wrote:
> > > Introduce a new "fast_gup" (for want of a better name right now)
> >
> > Perhaps,
> >
> > * get_address_space
> > * get_address_mappings
> > * get_mapped_pages
> > * get_page_mappings
> >
> > Or s@get_@ref_@?
>
> Why get_user_pages_lockless() is wrong?
> or get_my_pages() is better?
> (because this method assume task is current task)

Aw, nobody likes fast_gup? ;)

Technically get_user_pages_lockless is wrong: the implementation may
not be lockless so one cannot assume it will not take mmap sem and
ptls.

But I do like to make it clear that it is related to get_user_pages.
get_current_user_pages(), maybe? Hmm, that's harder to grep for
both then I guess. get_user_pages_current?