From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 8/10] mips: convert to generic helpers for IPI function calls Date: Fri, 30 May 2008 09:23:46 +0200 Message-ID: <20080530072346.GH25504@kernel.dk> References: <1212051504-12561-1-git-send-email-jens.axboe@oracle.com> <1212051504-12561-9-git-send-email-jens.axboe@oracle.com> <20080529142054.GA8320@linux-mips.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from brick.kernel.dk ([87.55.233.238]:10617 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbYE3HXs (ORCPT ); Fri, 30 May 2008 03:23:48 -0400 Content-Disposition: inline In-Reply-To: <20080529142054.GA8320@linux-mips.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ralf Baechle Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, npiggin@suse.de, linux-arch@vger.kernel.org, jeremy@goop.org, mingo@elte.hu, paulmck@linux.vnet.ibm.com On Thu, May 29 2008, Ralf Baechle wrote: > On Thu, May 29, 2008 at 10:58:22AM +0200, Jens Axboe wrote: > > > This converts mips to use the new helpers for smp_call_function() and > > friends, and adds support for smp_call_function_single(). Not tested, > > but it compiles. > > > > mips shares the same IPI for smp_call_function() and > > smp_call_function_single(), since not all hardware has enough available > > IPIs available to support seperate setups. > > FYI, the comment isn't quite accurate. The machanisms for IPIs on MIPS > are platform-specific. The change which I recently objected to was > specific to a code model called VSMP. So s/hardware/platform and you are happy? -- Jens Axboe