From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 52/60] microblaze_v4: fcntl.h sockios.h ucontext.h Date: Thu, 26 Jun 2008 18:46:12 +0200 Message-ID: <200806261846.13599.arnd@arndb.de> References: <1214483429-32360-1-git-send-email-monstr@seznam.cz> <1214483429-32360-53-git-send-email-monstr@seznam.cz> <200806261743.10441.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <200806261743.10441.arnd@arndb.de> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: monstr@seznam.cz Cc: linux-arch@vger.kernel.org, alan@lxorguk.ukuu.org.uk, Michal Simek , vapier.adi@gmail.com, matthew@wil.cx, microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org, drepper@redhat.com, linuxppc-dev@ozlabs.org, will.newton@gmail.com, hpa@zytor.com, John.Linn@xilinx.com, john.williams@petalogix.com List-Id: linux-arch.vger.kernel.org On Thursday 26 June 2008, Arnd Bergmann wrote: > On Thursday 26 June 2008, monstr@seznam.cz wrote: > > =A0include/asm-generic/sockios.h =A0 =A0 | =A0 23 +++++++++++++++++++++= ++ > > =A0include/asm-generic/ucontext.h =A0 =A0| =A0 24 +++++++++++++++++++++= +++ > > =A0include/asm-microblaze/fcntl.h =A0 =A0| =A0 =A01 + > > =A0include/asm-microblaze/sockios.h =A0| =A0 23 +++++++++++++++++++++++ > > =A0include/asm-microblaze/ucontext.h | =A0 =A01 + > = > Also, the sockios file here looks like it should be in asm-generic. I just realized that you are adding the same sockios file to both asm-generic and asm-microblaze, so I guess that is just an oversight and you meant the microblaze file to be just a redirection. Note that when you add an asm-generic header file that contains a user interface, you need to add it to asm-generic/Kbuild as well in order to get it installed correctly with make headers_install. Running make headers_check should tell you about this problem if it exists in other places. Arnd <>< From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.126.188]:61953 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbYFZRrm convert rfc822-to-8bit (ORCPT ); Thu, 26 Jun 2008 13:47:42 -0400 From: Arnd Bergmann Subject: Re: [PATCH 52/60] microblaze_v4: fcntl.h sockios.h ucontext.h Date: Thu, 26 Jun 2008 18:46:12 +0200 References: <1214483429-32360-1-git-send-email-monstr@seznam.cz> <1214483429-32360-53-git-send-email-monstr@seznam.cz> <200806261743.10441.arnd@arndb.de> In-Reply-To: <200806261743.10441.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-ID: <200806261846.13599.arnd@arndb.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: monstr@seznam.cz Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, stephen.neuendorffer@xilinx.com, John.Linn@xilinx.com, john.williams@petalogix.com, matthew@wil.cx, will.newton@gmail.com, drepper@redhat.com, microblaze-uclinux@itee.uq.edu.au, grant.likely@secretlab.ca, linuxppc-dev@ozlabs.org, vapier.adi@gmail.com, alan@lxorguk.ukuu.org.uk, hpa@zytor.com, Michal Simek Message-ID: <20080626164612.NstJ5PPU_P62vaxNPumPVRYTGrsav98zYl4RS6nYdk0@z> On Thursday 26 June 2008, Arnd Bergmann wrote: > On Thursday 26 June 2008, monstr@seznam.cz wrote: > >  include/asm-generic/sockios.h     |   23 +++++++++++++++++++++++ > >  include/asm-generic/ucontext.h    |   24 ++++++++++++++++++++++++ > >  include/asm-microblaze/fcntl.h    |    1 + > >  include/asm-microblaze/sockios.h  |   23 +++++++++++++++++++++++ > >  include/asm-microblaze/ucontext.h |    1 + > > Also, the sockios file here looks like it should be in asm-generic. I just realized that you are adding the same sockios file to both asm-generic and asm-microblaze, so I guess that is just an oversight and you meant the microblaze file to be just a redirection. Note that when you add an asm-generic header file that contains a user interface, you need to add it to asm-generic/Kbuild as well in order to get it installed correctly with make headers_install. Running make headers_check should tell you about this problem if it exists in other places. Arnd <><