From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: tzanussi@gmail.com, penberg@cs.helsinki.fi,
torvalds@linux-foundation.org, compudj@krystal.dyndns.org,
vegard.nossum@gmail.com, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 3/3] relay: Add buffer-only channels; useful for early logging.
Date: Sat, 5 Jul 2008 07:14:01 +0300 [thread overview]
Message-ID: <20080705071401.0fe75d9f@linux360.ro> (raw)
In-Reply-To: <20080702230636.66e484bb.akpm@linux-foundation.org>
On Wed, 2 Jul 2008 23:06:36 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> This breaks on sparc64.
>
> > + err = smp_call_function_single(i,
> > +
> > __relay_set_buf_dentry,
> > + &disp, 0,
> > 1);
>
> Because that ain't implemented.
>
> There's a call in net/iucv/iucv.c, but that's s390-only.
>
> There's a call in virt/kvm/kvm_main.c.
>
> There's a call in kernel/time/tick-broadcast.c, so I assume that the
> intersection between CONFIG_GENERIC_CLOCKEVENTS_BROADCAST and
> non-smp_call_function_single() architectures is presently empty.
Hi,
I'm not sure what I should do. Maybe disable relay_late_setup_files()
on sparc64, with an empty inline?
> I guess all SMP-capable architectures should now implement this,
> please. It is presently defined on all architectures for CONFIG_SMP=n
> and it is declared in include/linux/smp.h.
sparc64 seems to have smp_call_function_mask(). If we have the generic
kernel/smp.c in linux-next or -mmotm, then this will define
smp_call_function_single() to call smp_call_function_mask().
Is there anything I can do regarding this patch? Does it work since
kernel/smp.c reappeared?
Eduard
next prev parent reply other threads:[~2008-07-05 4:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080623153104.50549291@linux360.ro>
2008-07-03 6:06 ` [PATCH 3/3] relay: Add buffer-only channels; useful for early logging Andrew Morton
2008-07-05 4:14 ` Eduard - Gabriel Munteanu [this message]
2008-07-05 6:32 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080705071401.0fe75d9f@linux360.ro \
--to=eduard.munteanu@linux360.ro \
--cc=akpm@linux-foundation.org \
--cc=compudj@krystal.dyndns.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@linux-foundation.org \
--cc=tzanussi@gmail.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).