From: Russell King <rmk@arm.linux.org.uk>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH-mm] byteorder: wire up arches to use new headers
Date: Fri, 18 Jul 2008 14:36:27 +0100 [thread overview]
Message-ID: <20080718133627.GA25816@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1216337353.6029.66.camel@brick>
On Thu, Jul 17, 2008 at 04:29:13PM -0700, Harvey Harrison wrote:
> diff --git a/include/asm-arm/byteorder.h b/include/asm-arm/byteorder.h
> index e6f7fcd..d88a5ce 100644
> --- a/include/asm-arm/byteorder.h
> +++ b/include/asm-arm/byteorder.h
> @@ -18,7 +18,15 @@
> #include <linux/compiler.h>
> #include <asm/types.h>
>
> -static inline __attribute_const__ __u32 ___arch__swab32(__u32 x)
> +#ifdef __ARMEB__
> +# define __BIG_ENDIAN
> +#else
> +# define __LITTLE_ENDIAN
> +#endif
> +
> +#define __SWAB_64_THRU_32__
> +
> +static inline __attribute_const__ __u32 __arch_swab32(__u32 x)
> {
> __u32 t;
>
> @@ -40,19 +48,8 @@ static inline __attribute_const__ __u32 ___arch__swab32(__u32 x)
>
> return x;
> }
> +#define HAVE_ARCH_SWAB32
>
> -#define __arch__swab32(x) ___arch__swab32(x)
> -
> -#if !defined(__STRICT_ANSI__) || defined(__KERNEL__)
> -# define __BYTEORDER_HAS_U64__
> -# define __SWAB_64_THRU_32__
> -#endif
> -
> -#ifdef __ARMEB__
> -#include <linux/byteorder/big_endian.h>
> -#else
> -#include <linux/byteorder/little_endian.h>
> -#endif
> +#include <linux/byteorder.h>
>
> #endif
> -
For the above,
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
prev parent reply other threads:[~2008-07-18 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 23:29 [PATCH-mm] byteorder: wire up arches to use new headers Harvey Harrison
2008-07-17 23:44 ` Andrew Morton
2008-07-18 13:36 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080718133627.GA25816@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).