Re: drivers/usb/musb/musb_io.h

[Felipe Balbi <me@felipebalbi.com>]

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

On Fri, Aug 15, 2008 at 02:46:45PM -0700, David Brownell wrote:
> On Friday 15 August 2008, Felipe Balbi wrote:
> > So I think until we have a better solution we'll need the attached patch
> > to musb_io.h
> 
> Probably worth adding AVR32 to the list too.  I happened to
> enable musb during avr32 test build; it kablooied there too,
> but behaves given the CONFIG_AVR32 #ifdef.

Good to know, thanks.

Hmm... but how about the other version?

+#ifndef readsl
 static inline void readsl(const void __iomem *addr, void *buf, int len)
        { insl((unsigned long)addr, buf, len); }
+#endif
+#ifndef readsw
 static inline void readsw(const void __iomem *addr, void *buf, int len)
        { insw((unsigned long)addr, buf, len); }
+#endif

I think this would be a bit better since we don't need to keep adding
several archs to the list and prevents anything from breaking...
although those ifdefs look a bit odd.

> The existing #ifdef was sufficient to get a clean x86 build,
> given basic <linux/clk.h> support.  Someone wanting to see this
> driver work on the PCI (FPGA?) incarnation of this IP will
> have to solve that problem too.

Yeah... I have one of those OPTs, was even wondering on starting the pci
bus glue, but I'm too busy with nokia internal stuff for playing around
now :-s

Hope someone ever implement that, would be fun to see :-)

-- 
balbi

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]