From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
ying.huang@intel.com, linux-arch@vger.kernel.org,
linux-s390@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: + separate-atomic_t-declaration-from-asm-atomich-into-asm-atomic_defh.patch added to -mm tree
Date: Mon, 1 Sep 2008 11:21:40 +0200 [thread overview]
Message-ID: <200809011121.40686.borntraeger@de.ibm.com> (raw)
In-Reply-To: <20080822213624.GX8318@parisc-linux.org>
Am Freitag, 22. August 2008 schrieb Matthew Wilcox:
>
> S390 has an __aligned__((4)) on theirs -- is this really necessary?
> Doesn't s390 align ints to 4 bytes automatically? If it doesn't, it
Yes, the s390 abi requires a 4 byte alignment for int. The __aligned__((4))
looks unnecessary.
> +++ include/linux/atomic_type.h
> +typedef struct { volatile int counter; } atomic_t;
> +#ifdef CONFIG_64BIT
> +typedef struct { volatile long counter; } atomic64_t;
> +#endif
Hmm, the current s390 version has no volatile. I can recall some very long
mail threads about this. What was the outcome?
Christian
prev parent reply other threads:[~2008-09-01 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 20:56 + separate-atomic_t-declaration-from-asm-atomich-into-asm-atomic_defh.patch added to -mm tree akpm
2008-08-22 20:56 ` akpm
2008-08-22 21:36 ` Matthew Wilcox
2008-08-29 23:34 ` Matthew Wilcox
2008-08-30 0:19 ` Andrew Morton
2008-08-30 21:56 ` Roman Zippel
2008-09-01 9:21 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809011121.40686.borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mm-commits@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox