Re: CONFIG_HAVE_ARCH_TRACEHOOK and you

Roland McGrath
2008-09-12T22:33:04Z

> clean. The only thing I did do was invent some alternative simpler
> helper functions rather than using the user_regset_copy* functions (to
> avoid taking the address of function arguments, which needlessly forces
> them onto the stack.)

Ideally those would get inlined so that doesn't happen. Their only purpose
is to make it easier to write get/set functions in arch code. Whatever you
find preferable in your arch code is certainly fine with me. If you have
something different, or changes to those regset.h functions, that would be
of use for other arch code too, then bring them on (under a new subject
line if you don't mind).

> means sparc ends up allocating 38 * sizeof(u32) * sizeof(u32), and
> sparc64 ends up with 36 * sizeof(u64) * sizeof(u64), which must surely
> be wrong?

Yup! Sure looks like Dave skipped the step where it says "test that core
dumps work ... and produce correct results". :-)

Thanks,
Roland