From: Andrew Morton <akpm@linux-foundation.org>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, linux-arch@vger.kernel.org
Subject: Re: [PATCH] kernel/cpu.c: Section mismatch warning fix.
Date: Mon, 3 Nov 2008 15:34:25 -0800 [thread overview]
Message-ID: <20081103153425.7282ab84.akpm@linux-foundation.org> (raw)
In-Reply-To: <b9df5fa10810292104h38fcee68kae42cf5ab6275fbb@mail.gmail.com>
On Thu, 30 Oct 2008 10:04:54 +0600
"Rakib Mullick" <rakib.mullick@gmail.com> wrote:
> LD kernel/built-in.o
> WARNING: kernel/built-in.o(.text+0xb7c8): Section mismatch in
> reference from the function notify_cpu_starting() to the variable
> .cpuinit.data:cpu_chain
> The function notify_cpu_starting() references
> the variable __cpuinitdata cpu_chain.
> This is often because notify_cpu_starting lacks a __cpuinitdata
> annotation or the annotation of cpu_chain is wrong.
>
> This patch fixes the above section mismatch warning. If anything else
> please notice.
> Thanks.
>
> Signed-off-by: Md.Rakib H. Mullick <rakib.mullick@gmail.com>
>
> --- linux-2.6-orig/kernel/cpu.c 2008-10-28 20:52:38.000000000 +0600
> +++ linux-2.6/kernel/cpu.c 2008-10-28 22:46:22.000000000 +0600
> @@ -462,7 +462,7 @@ out:
> * It must be called by the arch code on the new cpu, before the new cpu
> * enables interrupts and before the "boot" cpu returns from __cpu_up().
> */
> -void notify_cpu_starting(unsigned int cpu)
> +void __cpuinit notify_cpu_starting(unsigned int cpu)
> {
> unsigned long val = CPU_STARTING;
arch/alpha/kernel/smp.c calls notify_cpu_starting() from __init code.
arch/cris/arch-v32/kernel/smp.c calls notify_cpu_starting() from __init code.
arch/x86/mach-voyager/voyager_smp.c calls notify_cpu_starting() from
__init code.
arch/m32r/kernel/smpboot.c calls notify_cpu_starting() from __init code.
arch/sparc/kernel/sun4d_smp.c calls notify_cpu_starting() from __init code.
arch/powerpc/kernel/smp.c calls notify_cpu_starting() from __devinit
code.
arch/um/kernel/smp.c calls notify_cpu_starting() from .text code.
The other nine callers call notify_cpu_starting() from __cpuinit code.
What a mess.
next parent reply other threads:[~2008-11-03 23:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b9df5fa10810292104h38fcee68kae42cf5ab6275fbb@mail.gmail.com>
2008-11-03 23:34 ` Andrew Morton [this message]
2008-11-04 9:48 ` [PATCH] kernel/cpu.c: Section mismatch warning fix Ingo Molnar
2008-11-04 10:09 ` Sam Ravnborg
2008-11-04 10:09 ` Sam Ravnborg
2008-11-04 10:22 ` Ingo Molnar
2008-11-04 11:02 ` Sam Ravnborg
2008-11-04 13:06 ` James Bottomley
2008-11-04 13:22 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081103153425.7282ab84.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox