public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Walle <bwalle@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, crash-utility@redhat.com
Subject: Re: [PATCH 3/3] Remove CONFIG_STRICT_DEVMEM
Date: Sun, 16 Nov 2008 16:21:49 +0100	[thread overview]
Message-ID: <20081116162149.07f05c7c@kopernikus.site> (raw)
In-Reply-To: <20081116150901.4d824e6d@lxorguk.ukuu.org.uk>

* Alan Cox [2008-11-16 15:09]:
>
> > -#ifdef CONFIG_STRICT_DEVMEM
> > -
> >  int devmem_restricted = 1;
> >  
> > -#if defined(CONFIG_SYSCTL) && defined(CONFIG_STRICT_DEVMEM)
> > +#if defined(CONFIG_SYSCTL)
> >  	/*
> >  	 * since there is no unload function, we don't have to deregister that
> >  	 * the whole lifetime of the kernel and can ignore the return value
> 
> NAK - this adds a pile of memory wasting complete crap to every kernel
> including embedded systems. At least before you could turn it off now you
> can't.

For embedded users, do they use CONFIG_SYSCTL at all? If not, then we
can just allow /dev/mem access when CONFIG_SYSCTL is turned on. That
should make embedded users happy.

But: I don't want to get that patch in. I just want to have the sysctl,
if just that patch doesn't make it, well, ok for me. I just think
CONFIG_STRICT_DEVMEM is superfluous when the runtime configuration
option is present.


Regards,
Bernhard

  parent reply	other threads:[~2008-11-16 15:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-16 14:47 Turn CONFIG_STRICT_DEVMEM in sysctl dev.mem.restricted Bernhard Walle
2008-11-16 14:47 ` [PATCH 1/3] Unify devmem_is_allowed across architectures Bernhard Walle
2008-11-16 14:47 ` [PATCH 2/3] Add dev.mem.restricted sysctl Bernhard Walle
2008-11-16 15:07   ` Willy Tarreau
2008-11-16 14:47 ` [PATCH 3/3] Remove CONFIG_STRICT_DEVMEM Bernhard Walle
2008-11-16 15:09   ` Alan Cox
2008-11-16 15:09     ` Alan Cox
2008-11-16 15:21     ` Bernhard Walle [this message]
2008-11-16 15:46       ` Alan Cox
2008-11-16 15:46         ` Alan Cox
2008-11-17 13:57       ` David Howells
2008-11-16 15:07 ` Turn CONFIG_STRICT_DEVMEM in sysctl dev.mem.restricted Alan Cox
2008-11-16 15:07   ` Alan Cox
2008-11-16 15:20   ` Bernhard Walle
2008-11-16 15:45     ` Alan Cox
2008-11-16 15:45       ` Alan Cox
2008-11-16 16:03       ` Arjan van de Ven
2008-11-16 16:09         ` Alan Cox
2008-11-16 16:09           ` Alan Cox
2008-11-16 16:19         ` Bernhard Walle
2008-11-16 16:11       ` Bernhard Walle
2008-11-16 17:03         ` Alan Cox
2008-11-16 17:03           ` Alan Cox
2008-11-16 15:39 ` Arjan van de Ven
2008-11-16 15:39   ` Arjan van de Ven
2008-11-16 15:56   ` Bernhard Walle
2008-11-16 16:06     ` Arjan van de Ven
2008-11-16 20:32   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081116162149.07f05c7c@kopernikus.site \
    --to=bwalle@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=crash-utility@redhat.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox