Re: [PATCH 05/12] PCI: add pci_swizzle_interrupt_pin()

David Howells
2008-12-11T18:16:26Z

Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:

> +/**
> + * pci_swizzle_interrupt_pin - swizzle INTx for device behind bridge
> + * @dev: the PCI device
> + * @pin: the INTx pin (1=INTA, 2=INTB, 3=INTD, 4=INTD)
> + *
> + * The PCI-to-PCI bridge specification, section 9.1, requires INTx swizzling
> + * for devices behind bridges on add-in cards. This performs the swizzle
> + * for one level of bridge.
> + */

That's okay. It might be better to put the what before the why, though:

* Perform INTx swizzling for a device behind one level of bridge. This is
* required by section 9.1 of the PCI-to-PCI bridge specification for devices
* behind bridges on add-in cards.

David