From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH -mmotm] mm: unify some pmd_*() functions Date: Tue, 27 Jan 2009 17:41:58 -0800 Message-ID: <20090127174158.519e5abd.akpm@linux-foundation.org> References: <1232919337-21434-1-git-send-email-righi.andrea@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1232919337-21434-1-git-send-email-righi.andrea@gmail.com> Sender: owner-linux-mm@kvack.org Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, righi.andrea@gmail.com, Geert Uytterhoeven , Roman Zippel , David Howells , Hirokazu Takata List-Id: linux-arch.vger.kernel.org On Sun, 25 Jan 2009 22:35:37 +0100 Andrea Righi wrote: > diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h > index a7cdc48..b132d69 100644 > --- a/include/asm-generic/pgtable-nopmd.h > +++ b/include/asm-generic/pgtable-nopmd.h > @@ -4,6 +4,7 @@ > #ifndef __ASSEMBLY__ > > #include > +#include > > struct mm_struct; > Why not include the preferred ? > BTW, I only tested this on x86 and x86_64. This needs more testing because it > touches also a lot of other architectures. Hopefully Geert, Roman, David and Hirokazu Takata will have time to help out here. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:49991 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586AbZA1Bmi (ORCPT ); Tue, 27 Jan 2009 20:42:38 -0500 Date: Tue, 27 Jan 2009 17:41:58 -0800 From: Andrew Morton Subject: Re: [PATCH -mmotm] mm: unify some pmd_*() functions Message-ID: <20090127174158.519e5abd.akpm@linux-foundation.org> In-Reply-To: <1232919337-21434-1-git-send-email-righi.andrea@gmail.com> References: <1232919337-21434-1-git-send-email-righi.andrea@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andrea Righi Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Roman Zippel , David Howells , Hirokazu Takata Message-ID: <20090128014158.fML4NnlVkCKoEwSyBkE2HRHYsshO2chDw81S-cWVatU@z> On Sun, 25 Jan 2009 22:35:37 +0100 Andrea Righi wrote: > diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h > index a7cdc48..b132d69 100644 > --- a/include/asm-generic/pgtable-nopmd.h > +++ b/include/asm-generic/pgtable-nopmd.h > @@ -4,6 +4,7 @@ > #ifndef __ASSEMBLY__ > > #include > +#include > > struct mm_struct; > Why not include the preferred ? > BTW, I only tested this on x86 and x86_64. This needs more testing because it > touches also a lot of other architectures. Hopefully Geert, Roman, David and Hirokazu Takata will have time to help out here.