From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [GIT PULL] Microblaze initial pack Date: Fri, 27 Mar 2009 11:40:45 +0100 Message-ID: <20090327104045.GA11518@elte.hu> References: <49CC8A41.4060503@monstr.eu> <20090327103032.GA12485@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:53911 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751842AbZC0KlT (ORCPT ); Fri, 27 Mar 2009 06:41:19 -0400 Content-Disposition: inline In-Reply-To: <20090327103032.GA12485@elte.hu> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Michal Simek , Alan Cox Cc: torvalds@linux-foundation.org, Linux Kernel list , lkml , microblaze-uclinux@itee.uq.edu.au, Andrew Morton , John Williams , John Linn , Stephen Neuendorffer , Thomas Gleixner , Randy Dunlap , Arnd Bergmann , Peter Korsgaard * Ingo Molnar wrote: > I have noticed one relatively big (but easily fixable) commit > structure problem in this tree. > > All of the commits have these tags: > > Reviewed-by: Stephen Neuendorffer > Acked-by: John Linn > Acked-by: John Williams I forgot to mention that in any case _your_ signoff as the submitter of this tree should be in all commits as well. So for example this (sample) chain would be fine: Reviewed-by: Stephen Neuendorffer Acked-by: John Linn Acked-by: John Williams Signed-off-by: Michal Simek It's not enough to be listed as the author in the commit. (In any case please see Documentation/SubmittingPatches and the DCO 1.1.) Also, a minor stylistic detail, please fix this: John Williams to: John Williams Thanks, Ingo