From: Sam Ravnborg <sam@ravnborg.org>
To: liqin.chen@sunplusct.com
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH 6/13] score - New architecure port to SunplusCT S+CORE processor
Date: Fri, 27 Mar 2009 19:45:22 +0100 [thread overview]
Message-ID: <20090327184522.GC21149@uranus.ravnborg.org> (raw)
In-Reply-To: <OF48378D81.6667BB0D-ON48257586.0008F474-48257586.00093CBC@sunplusct.com>
> linux-2.6-git.ori/arch/score/include/asm/types.h
> linux-2.6-git.new/arch/score/include/asm/types.h
> --- linux-2.6-git.ori/arch/score/include/asm/types.h 1970-01-01
> 08:00:00.000000000 +0800
> +++ linux-2.6-git.new/arch/score/include/asm/types.h 2009-03-23
> 15:03:24.000000000 +0800
> @@ -0,0 +1,24 @@
> +#ifndef _ASM_TYPES_H
> +#define _ASM_TYPES_H
> +
> +#include <asm-generic/int-ll64.h>
> +
> +#ifndef __ASSEMBLY__
> +typedef unsigned short umode_t;
> +#endif /* __ASSEMBLY__ */
> +
> +#ifdef __KERNEL__
> +#define BITS_PER_LONG 32
> +#ifndef __ASSEMBLY__
> +
> +typedef u32 dma_addr_t;
> +typedef u64 dma64_addr_t;
> +
> +/*
> + * Don't use phys_t. You've been warned.
> + */
> +typedef unsigned long phys_t;
If you do not use it drop it from this file.
> diff -uprN -x linux-2.6-git.ori/Documentation/dontdiff
> linux-2.6-git.ori/arch/score/include/asm/unaligned.h
> linux-2.6-git.new/arch/score/include/asm/unaligned.h
> --- linux-2.6-git.ori/arch/score/include/asm/unaligned.h 1970-01-01
> 08:00:00.000000000 +0800
> +++ linux-2.6-git.new/arch/score/include/asm/unaligned.h 2009-03-23
> 15:07:26.000000000 +0800
> @@ -0,0 +1,21 @@
> +#ifndef _ASM_SCORE_UNALIGNED_H
> +#define _ASM_SCORE_UNALIGNED_H
> +
> +#include <linux/compiler.h>
> +#if defined(__SCOREEB__)
> +# include <linux/unaligned/be_struct.h>
> +# include <linux/unaligned/le_byteshift.h>
> +# include <linux/unaligned/generic.h>
> +# define get_unaligned __get_unaligned_be
> +# define put_unaligned __put_unaligned_be
> +#elif defined(__SCOREEL__)
> +# include <linux/unaligned/le_struct.h>
> +# include <linux/unaligned/be_byteshift.h>
> +# include <linux/unaligned/generic.h>
> +# define get_unaligned __get_unaligned_le
> +# define put_unaligned __put_unaligned_le
> +#else
> +# error "SCORE, but neither __SCOREEB__, nor __SCOREEL__???"
> +#endif
Where does __SCOREEB__ and __SCOREEL__ comes from?
Can we use a CONFIG_ symbol here?
The header is not exported so it is OK to use CONFIG_ and
if we can puch the definition to Kconfig time then this is preferred.
Sam
prev parent reply other threads:[~2009-03-27 18:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 1:39 [PATCH 6/13] score - New architecure port to SunplusCT S+CORE processor liqin.chen
2009-03-27 18:45 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327184522.GC21149@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqin.chen@sunplusct.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox