From: Andrew Morton <akpm@linux-foundation.org>
To: liqin.chen@sunplusct.com
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, Arnd Bergmann <arnd@arndb.de>,
Sam Ravnborg <sam@ravnborg.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kyle McMartin <kyle@mcmartin.ca>
Subject: Re: [PATCH 2/14] score - New architecure port to SunplusCT S+CORE
Date: Thu, 9 Apr 2009 23:12:08 -0700 [thread overview]
Message-ID: <20090409231208.558c0983.akpm@linux-foundation.org> (raw)
In-Reply-To: <OF522DF4EC.299F045D-ON48257592.00284C5F-48257592.00289156@sunplusct.com>
On Wed, 8 Apr 2009 15:21:00 +0800 liqin.chen@sunplusct.com wrote:
> From: Chen Liqin <liqin.chen@sunplusct.com>
>
> asm/asm.h, asm/atomic.h, asm/auxvec.h, asm/bitops.h, asm/bug.h,
> asm/bugs.h, asm/byteorder.h, asm/cacheflush.h, asm/cache.h
> and asm/checksum.h for the score architecture.
>
>
> ...
>
> +#define PG_dcache_dirty PG_arch_1
> +
> +#define Page_dcache_dirty(page) \
> + test_bit(PG_dcache_dirty, &(page)->flags)
> +#define SetPageDcacheDirty(page) \
> + set_bit(PG_dcache_dirty, &(page)->flags)
> +#define ClearPageDcacheDirty(page) \
> + clear_bit(PG_dcache_dirty, &(page)->flags)
We have ugly macros in include/linux/page-flags.h which expand a page
flag out into its accessors, with standardised naming: TESTSCFLAG,
CLEARPAGEFLAG_NOOP, etc.
It would be best of those were reused here.
>
> ...
>
prev parent reply other threads:[~2009-04-10 6:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 7:21 [PATCH 2/14] score - New architecure port to SunplusCT S+CORE liqin.chen
2009-04-10 6:12 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409231208.558c0983.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=kyle@mcmartin.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqin.chen@sunplusct.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox