From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 2/14] score - New architecure port to SunplusCT S+CORE Date: Thu, 9 Apr 2009 23:12:08 -0700 Message-ID: <20090409231208.558c0983.akpm@linux-foundation.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:34523 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758384AbZDJGQe (ORCPT ); Fri, 10 Apr 2009 02:16:34 -0400 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: liqin.chen@sunplusct.com Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, Arnd Bergmann , Sam Ravnborg , Thomas Gleixner , Kyle McMartin On Wed, 8 Apr 2009 15:21:00 +0800 liqin.chen@sunplusct.com wrote: > From: Chen Liqin > > asm/asm.h, asm/atomic.h, asm/auxvec.h, asm/bitops.h, asm/bug.h, > asm/bugs.h, asm/byteorder.h, asm/cacheflush.h, asm/cache.h > and asm/checksum.h for the score architecture. > > > ... > > +#define PG_dcache_dirty PG_arch_1 > + > +#define Page_dcache_dirty(page) \ > + test_bit(PG_dcache_dirty, &(page)->flags) > +#define SetPageDcacheDirty(page) \ > + set_bit(PG_dcache_dirty, &(page)->flags) > +#define ClearPageDcacheDirty(page) \ > + clear_bit(PG_dcache_dirty, &(page)->flags) We have ugly macros in include/linux/page-flags.h which expand a page flag out into its accessors, with standardised naming: TESTSCFLAG, CLEARPAGEFLAG_NOOP, etc. It would be best of those were reused here. > > ... >