From: Andrew Morton <akpm@linux-foundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, x86@kernel.org, rth@twiddle.net,
ralf@linux-mips.org, tiwai@suse.de, dmitry.torokhov@gmail.com,
mingo@elte.hu, linux-kernel@vger.kernel.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] move PIT_TICK_RATE to linux/timex.h
Date: Mon, 11 May 2009 17:01:46 -0700 [thread overview]
Message-ID: <20090511170146.143a1551.akpm@linux-foundation.org> (raw)
In-Reply-To: <200905112255.37215.arnd@arndb.de>
On Mon, 11 May 2009 22:55:36 +0000
Arnd Bergmann <arnd@arndb.de> wrote:
> PIT_TICK_RATE is currently defined in four architectures,
> but in three different places. While linux/timex.h is not
> the perfect place for it, it is still a reasonable replacement
> for those drivers that traditionally use asm/timex.h to
> get CLOCK_TICK_RATE and expect it to be the PIT frequency.
>
> ...
>
> -#define PIT_TICK_RATE 1193180UL
> -#define PIT_TICK_RATE 1193182UL
> -#define PIT_TICK_RATE 1193182UL
> -#define PIT_TICK_RATE 1193182
> +#define PIT_TICK_RATE 1193182ul
So the type got changed in arch/x86/include/asm/timex.h. Did you check
whether that changes anything? I did a quick check and didn't see any
obvious problems..
next prev parent reply other threads:[~2009-05-12 0:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090511222702.352192505@arndb.de>
2009-05-11 22:43 ` [PATCH] arm: rename CLOCK_TICK_RATE to ARM_TICK_RATE Arnd Bergmann
2009-05-11 23:11 ` [PATCH v2] " Arnd Bergmann
2009-05-13 17:11 ` [PATCH] " Arnd Bergmann
2009-05-11 22:55 ` [PATCH] move PIT_TICK_RATE to linux/timex.h Arnd Bergmann
2009-05-11 22:55 ` Arnd Bergmann
2009-05-12 0:01 ` Andrew Morton [this message]
2009-05-12 0:36 ` Arnd Bergmann
[not found] ` <200905121104.31275.arnd@arndb.de>
[not found] ` <20090512091010.GD18004@elte.hu>
2009-05-12 11:42 ` [PATCH v2] x86: fix ktermios-termio conversion Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511170146.143a1551.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=tiwai@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox