From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
kvm <kvm@vger.kernel.org>,
DLE <dle-develop@lists.sourceforge.net>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Roland McGrath <roland@redhat.com>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH -tip v8 5/7] x86: add pt_regs register and stack access APIs
Date: Tue, 2 Jun 2009 01:40:06 +0200 [thread overview]
Message-ID: <20090601234006.GA12629@elte.hu> (raw)
In-Reply-To: <20090530081303.GB15755@infradead.org>
* Christoph Hellwig <hch@infradead.org> wrote:
> > + if (n < NR_REGPARMS) {
> > + switch (n) {
> > + case 0: return regs->ax;
> > + case 1: return regs->dx;
> > + case 2: return regs->cx;
> > + }
>
> Normal kernel style would be
>
> switch (n) {
> case 0:
> return regs->ax;
> case 1:
> return regs->dx;
> case 2:
> return regs->cx;
> }
the original single-line shortcut is acceptable too.
Ingo
next prev parent reply other threads:[~2009-06-01 23:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090529000326.17532.70868.stgit@localhost.localdomain>
[not found] ` <20090529000347.17532.34038.stgit@localhost.localdomain>
2009-05-30 8:13 ` [PATCH -tip v8 5/7] x86: add pt_regs register and stack access APIs Christoph Hellwig
2009-05-30 14:48 ` Masami Hiramatsu
2009-06-01 23:40 ` Ingo Molnar [this message]
2009-06-01 23:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601234006.GA12629@elte.hu \
--to=mingo@elte.hu \
--cc=ananth@in.ibm.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox