Re: [PATCH 01/27] score: create Kconfig Kconfig.debug Makefile

[Arnd Bergmann <arnd@arndb.de>]

On Tuesday 09 June 2009, liqin.chen@sunplusct.com wrote:

> +++ b/arch/score/Kconfig
> @@ -0,0 +1,243 @@
> +config SCORE
> +       bool
> +       default y
> +       select EMBEDDED

I don't think you should select EMBEDDED. The option is slightly
misnamed and just enables some other config options. If you need
any of those that are protected by EMBEDDED, then maybe select those
directly.

> +config NO_DMA
> +       bool
> +       default y

Are you planning to implement DMA support? We just had a lenghty
discussion about how to do it generically. While we did not find
a solution, you can probably easily take the
asm-generic/dma-mapping-linear.h I posted and adapt that to your
needs.

> +config SCORE_L1_CACHE_SHIFT
> +       int
> +       default "5"

Your arch/score/include/asm/cache.h contains

#define L1_CACHE_SHIFT         4

One of the two looks wrong ;-)

If you have different cache implementations, this value
should probably be the maximum of all CPUs that are configured
in the kernel.

> +config HZ
> +       int
> +       default 100

Have you looked into implementing NO_HZ? It is not required in any
way, but can probably reduce your power consumption, which may be
interesting for embedded systems.

> +config KEXEC
> +       bool "Kexec system call (EXPERIMENTAL)"
> +       depends on EXPERIMENTAL
> +       help

Do you actually support this? I did not look very closely,
but could not find anything about kexec in the other patches.
If not, just drop the config option.

	Arnd <><