From: Andi Kleen <andi@firstfloor.org>
To: liqin.chen@sunplusct.com
Cc: Andi Kleen <andi@firstfloor.org>,
Christoph Hellwig <hch@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: S+core architecture (arch/score/) support files
Date: Wed, 24 Jun 2009 09:07:08 +0200 [thread overview]
Message-ID: <20090624070708.GI6760@one.firstfloor.org> (raw)
In-Reply-To: <OF06F6A918.AA4716A4-ON482575DF.000B4993-482575DF.0013010F@sunplusct.com>
> I think merge score to upstream will be no harm to linux kernel.
The problem is just that if the code is not tested in its
current configuration it will most likely not work (unless you're a perfect
coder, but most of us are not). And merging code that doesn't work doesn't
make sense.
The need for a full retest after the changes inspired by review
feedback is somewhat annoying -- I agree -- but there's really
no way around it that I know.
BTW I'm not saying that LTP is the perfect user test (it's definitely
not), but it's a relatively useful basic sanity check and you
should pass something like this at least. Other real user testing would
be still needed too of course then.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-06-24 7:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 8:37 S+core architecture (arch/score/) support files liqin.chen
2009-06-23 9:43 ` Arnd Bergmann
2009-06-23 10:51 ` liqin.chen
2009-06-23 12:06 ` Andi Kleen
2009-06-23 13:55 ` Arnd Bergmann
2009-06-23 14:30 ` Andi Kleen
2009-06-24 3:22 ` liqin.chen
2009-06-24 7:07 ` Andi Kleen [this message]
2009-06-25 3:00 ` liqin.chen
2009-06-23 14:50 ` Christoph Hellwig
2009-07-08 10:53 ` [PATCH] score: add regsets support for score liqin.chen
2009-07-09 15:08 ` Arnd Bergmann
2009-07-09 21:03 ` Roland McGrath
2009-07-10 9:06 ` liqin.chen
2009-07-10 9:43 ` liqin.chen
2009-07-10 10:44 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090624070708.GI6760@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=hch@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqin.chen@sunplusct.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).