Re: handle_mm_fault() calling convention cleanup..

David Miller
2009-06-22T02:20:01Z

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun, 21 Jun 2009 13:42:35 -0700 (PDT)

> I fixed up all architectures that I noticed (at least microblaze had been
> added since the original patches in April), but arch maintainers should
> double-check. Arch maintainers might also want to check whether the
> mindless conversion of
>
> 'is_write' => 'is_write ? FAULT_FLAGS_WRITE : 0'
>
> might perhaps be written in some more natural way (for example, maybe
> you'd like to get rid of 'iswrite' as a variable entirely, and replace it
> with a 'fault_flags' variable).
>
> It's pushed out and tested on x86-64, but it really was such a mindless
> conversion that I hope it works on all architectures. But I thought I'd
> better give people a shout-out regardless.

Sparc looks good, and sparc64 seems to work fine.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: email@kvack.org