Re: handle_mm_fault() calling convention cleanup..

Nick Piggin
2009-07-06T07:31:47Z

On Sun, Jul 05, 2009 at 07:08:38AM +1000, Benjamin Herrenschmidt wrote:
> On Sat, 2009-07-04 at 09:44 -0700, Linus Torvalds wrote:
>
> > Just a tiny word of warning: right now, the conversion I did pretty much
> > depended on the fact that even if I missed a spot, it wouldn't actually
> > make any difference. If somebody used "flags" as a binary value (ie like
> > the old "write_access" kind of semantics), things would still all work,
> > because it was still a "zero-vs-nonzero" issue wrt writes.
>
> .../...
>
> Right. Oh well.. we'll see when I get to it. I have a few higher
> priority things on my pile at the moment.

I have no problems with that. I'd always intended to have flags
go further up the call chain like Linus did (since we'd discussed
perhaps making faults interruptible and requiring an extra flag
to distinguish get_user_pages callers that were not interruptible).

So yes adding more flags to improve code or make things simpler
is fine by me :)

Thanks,
Nick