public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: liqin.chen@sunplusct.com, Christoph Hellwig <hch@infradead.org>,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH V2] score: add regset support
Date: Wed, 15 Jul 2009 13:18:17 -0700 (PDT)	[thread overview]
Message-ID: <20090715201817.9FF0840F7F@magilla.sf.frob.com> (raw)
In-Reply-To: Arnd Bergmann's message of  Monday, 13 July 2009 16:24:28 +0200 <200907131624.28286.arnd@arndb.de>

IMHO it is certainly a wise choice to have some struct (be it called
user_regs_struct or whatever) that describes the exact userland layout.
(I think it's also fine to just call that elf_gregset_t and have it be an
array, with REG_* defines/enum somewhere to document its indices.  It's
just a matter of taste for the arch folks.)

Given such a struct, the regset code can refer to it (with offsetof, e.g.)
and that will make it far easier to read, understand, and review.


Thanks,
Roland

      parent reply	other threads:[~2009-07-15 20:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-10  9:13 [PATCH V2] score: add regset support liqin.chen
2009-07-10 12:49 ` Arnd Bergmann
2009-07-13  5:56   ` liqin.chen
2009-07-13 14:24     ` Arnd Bergmann
2009-07-14  1:42       ` liqin.chen
2009-07-15 20:18       ` Roland McGrath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090715201817.9FF0840F7F@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=arnd@arndb.de \
    --cc=hch@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liqin.chen@sunplusct.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox