From: Sam Ravnborg <sam@ravnborg.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arch@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Ian Campbell <icampbell@arcom.com>,
Mike Frysinger <vapier@gentoo.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Hirokazu Takata <takata@linux-m32r.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Kyle McMartin <kyle@mcmartin.ca>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Paul Mundt <lethal@linux-sh.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH/RFC] kbuild: use INSTALLKERNEL to select customized installkernel script
Date: Tue, 21 Jul 2009 09:18:36 +0200 [thread overview]
Message-ID: <20090721071836.GA7210@merkur.ravnborg.org> (raw)
In-Reply-To: <4A651863.6090009@zytor.com>
On Mon, Jul 20, 2009 at 06:22:43PM -0700, H. Peter Anvin wrote:
> Russell King - ARM Linux wrote:
> >
> > That's a good thing in some ways and a bad thing in others. Having
> > it guarantee to fail if you try installing an ARM kernel onto an
> > x86 machine is definitely a good thing. That said, it's not something
> > I've ever accidentally done.
> >
>
> I guess we could have it error out if you are building a non-native
> architecture but don't set CROSS_COMPILE. Either that or we could
> default $INSTALLKERNEL to $(CROSS_COMPILE)installkernel, which would be
> backwards compatible.
I had googled a bit to try to analyse how much use
this feature has seen.
And I only managed to find the original patch implementing this.
None of the books I found mention this in their
install kernel chapets either.
So the conclusion - it is not widely used.
Russell is right that one implicit use is that "make CROSS_COMPILE=foo install"
would fail. And with this patch it would succeed.
Trying to error out is we are doing a non-native build is not the
right answer. People may like to have a custom script that can
ftp the new kernel somewhere or stuff like that.
All that combined with the fact that using the binutils/gcc
CROSS_COMPILE prefix is the wrong solution anyway made me
conclude that we should fix this rather than implement it
in a different way.
That combined with the fact that CROSS_COMPILE has two
primary usages:
- binutils/gcc prefix when building for another architecture
- distcc/ccache
The latter does not fit well with the installkernel use.
I briefly looked into creating another way to specify
distcc / ccache.
But the current way to do things works well - so I dropped it again.
Sam
prev parent reply other threads:[~2009-07-21 7:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 20:11 [PATCH/RFC] kbuild: use INSTALLKERNEL to select customized installkernel script Sam Ravnborg
2009-07-20 20:19 ` H. Peter Anvin
2009-07-20 20:49 ` Paul Mundt
2009-07-20 22:11 ` Russell King - ARM Linux
2009-07-21 1:22 ` H. Peter Anvin
2009-07-21 7:18 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721071836.GA7210@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=benh@kernel.crashing.org \
--cc=fenghua.yu@intel.com \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=icampbell@arcom.com \
--cc=kyle@mcmartin.ca \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=takata@linux-m32r.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).