From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] Drop superfluous casts in nr_free_pages() callers Date: Mon, 3 Aug 2009 19:22:56 +0200 Message-ID: <20090803172256.GA26766@elte.hu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Christoph Lameter , Andrew Morton , linux-arch@vger.kernel.org, Linux Kernel Development List-Id: linux-arch.vger.kernel.org * Geert Uytterhoeven wrote: > Commit 96177299416dbccb73b54e6b344260154a445375 ("Drop free_pages()") > modified nr_free_pages() to return 'unsigned long' instead of 'unsigned int'. > This made the casts to 'unsigned long' in most callers superfluous, hence > remove them. > diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c > index 3cd7711..95e877f 100644 > --- a/arch/x86/mm/init_32.c > +++ b/arch/x86/mm/init_32.c > @@ -892,7 +892,7 @@ void __init mem_init(void) > > printk(KERN_INFO "Memory: %luk/%luk available (%dk kernel code, " > "%dk reserved, %dk data, %dk init, %ldk highmem)\n", > - (unsigned long) nr_free_pages() << (PAGE_SHIFT-10), > + nr_free_pages() << (PAGE_SHIFT-10), > num_physpages << (PAGE_SHIFT-10), > codesize >> 10, > reservedpages << (PAGE_SHIFT-10), > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index 6176fe8..44f82a6 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -687,7 +687,7 @@ void __init mem_init(void) > > printk(KERN_INFO "Memory: %luk/%luk available (%ldk kernel code, " > "%ldk absent, %ldk reserved, %ldk data, %ldk init)\n", > - (unsigned long) nr_free_pages() << (PAGE_SHIFT-10), > + nr_free_pages() << (PAGE_SHIFT-10), > max_pfn << (PAGE_SHIFT-10), > codesize >> 10, > absent_pages << (PAGE_SHIFT-10), Acked-by: Ingo Molnar Thanks Geert, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3.mail.elte.hu ([157.181.1.138]:52396 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458AbZHCRXI (ORCPT ); Mon, 3 Aug 2009 13:23:08 -0400 Date: Mon, 3 Aug 2009 19:22:56 +0200 From: Ingo Molnar Subject: Re: [PATCH] Drop superfluous casts in nr_free_pages() callers Message-ID: <20090803172256.GA26766@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: Christoph Lameter , Andrew Morton , linux-arch@vger.kernel.org, Linux Kernel Development Message-ID: <20090803172256.jr6L7aUfgMR8CFKmRCBJqIpCa8rpVRah74j9aW05KMo@z> * Geert Uytterhoeven wrote: > Commit 96177299416dbccb73b54e6b344260154a445375 ("Drop free_pages()") > modified nr_free_pages() to return 'unsigned long' instead of 'unsigned int'. > This made the casts to 'unsigned long' in most callers superfluous, hence > remove them. > diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c > index 3cd7711..95e877f 100644 > --- a/arch/x86/mm/init_32.c > +++ b/arch/x86/mm/init_32.c > @@ -892,7 +892,7 @@ void __init mem_init(void) > > printk(KERN_INFO "Memory: %luk/%luk available (%dk kernel code, " > "%dk reserved, %dk data, %dk init, %ldk highmem)\n", > - (unsigned long) nr_free_pages() << (PAGE_SHIFT-10), > + nr_free_pages() << (PAGE_SHIFT-10), > num_physpages << (PAGE_SHIFT-10), > codesize >> 10, > reservedpages << (PAGE_SHIFT-10), > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index 6176fe8..44f82a6 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -687,7 +687,7 @@ void __init mem_init(void) > > printk(KERN_INFO "Memory: %luk/%luk available (%ldk kernel code, " > "%ldk absent, %ldk reserved, %ldk data, %ldk init)\n", > - (unsigned long) nr_free_pages() << (PAGE_SHIFT-10), > + nr_free_pages() << (PAGE_SHIFT-10), > max_pfn << (PAGE_SHIFT-10), > codesize >> 10, > absent_pages << (PAGE_SHIFT-10), Acked-by: Ingo Molnar Thanks Geert, Ingo