From: Russell King <rmk@arm.linux.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: jmorris@namei.org, linux-security-module@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH [try #4] 8/9] KEYS: Extend TIF_NOTIFY_RESUME to (almost) all architectures
Date: Tue, 1 Sep 2009 18:16:49 +0100 [thread overview]
Message-ID: <20090901171649.GA16779@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20090901163307.14180.64201.stgit@warthog.procyon.org.uk>
On Tue, Sep 01, 2009 at 05:33:07PM +0100, David Howells wrote:
> diff --git a/arch/arm/include/asm/thread_info.h b/arch/arm/include/asm/thread_info.h
> index 73394e5..d3a39b1 100644
> --- a/arch/arm/include/asm/thread_info.h
> +++ b/arch/arm/include/asm/thread_info.h
> @@ -130,11 +130,13 @@ extern void vfp_sync_state(struct thread_info *thread);
> * TIF_SYSCALL_TRACE - syscall trace active
> * TIF_SIGPENDING - signal pending
> * TIF_NEED_RESCHED - rescheduling necessary
> + * TIF_NOTIFY_RESUME - callback before returning to user
> * TIF_USEDFPU - FPU was used by this task this quantum (SMP)
> * TIF_POLLING_NRFLAG - true if poll_idle() is polling TIF_NEED_RESCHED
> */
> #define TIF_SIGPENDING 0
> #define TIF_NEED_RESCHED 1
> +#define TIF_NOTIFY_RESUME 2 /* callback before returning to user */
> #define TIF_SYSCALL_TRACE 8
> #define TIF_POLLING_NRFLAG 16
> #define TIF_USING_IWMMXT 17
> @@ -143,6 +145,7 @@ extern void vfp_sync_state(struct thread_info *thread);
>
> #define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
> #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
> +#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)
> #define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE)
> #define _TIF_POLLING_NRFLAG (1 << TIF_POLLING_NRFLAG)
> #define _TIF_USING_IWMMXT (1 << TIF_USING_IWMMXT)
> diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
> index 8c3de1a..7813ab7 100644
> --- a/arch/arm/kernel/entry-common.S
> +++ b/arch/arm/kernel/entry-common.S
> @@ -51,7 +51,7 @@ fast_work_pending:
> work_pending:
> tst r1, #_TIF_NEED_RESCHED
> bne work_resched
> - tst r1, #_TIF_SIGPENDING
> + tst r1, #_TIF_SIGPENDING|_TIF_NOTIFY_RESUME
> beq no_work_pending
> mov r0, sp @ 'regs'
> mov r2, why @ 'syscall'
> diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
> index f6bc5d4..6759f45 100644
> --- a/arch/arm/kernel/signal.c
> +++ b/arch/arm/kernel/signal.c
> @@ -707,4 +707,9 @@ do_notify_resume(struct pt_regs *regs, unsigned int thread_flags, int syscall)
> {
> if (thread_flags & _TIF_SIGPENDING)
> do_signal(¤t->blocked, regs, syscall);
> +
> + if (thread_info_flags & _TIF_NOTIFY_RESUME) {
Shouldn't this be thread_flags ?
> + clear_thread_flag(TIF_NOTIFY_RESUME);
> + tracehook_notify_resume(regs);
> + }
> }
Apart from that, patch looks fine to me.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2009-09-01 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090901163231.14180.43426.stgit@warthog.procyon.org.uk>
2009-09-01 16:33 ` [PATCH [try #4] 8/9] KEYS: Extend TIF_NOTIFY_RESUME to (almost) all architectures David Howells
2009-09-01 17:16 ` Russell King [this message]
2009-09-01 17:16 ` Russell King
2009-09-01 17:26 ` David Howells
2009-09-01 17:26 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901171649.GA16779@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox