linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Chen Liqin <liqin.chen@sunplusct.com>
Cc: Tim Abbott <tabbott@ksplice.com>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	liqin.gnu@gmail.com
Subject: Re: [PATCH 1/2] score: add head files define in vmlinux.lds.S
Date: Tue, 22 Sep 2009 09:37:18 +0200	[thread overview]
Message-ID: <20090922073718.GA29384@merkur.ravnborg.org> (raw)
In-Reply-To: <1253601122.27225.2.camel@ad3ser01>

On Tue, Sep 22, 2009 at 02:32:02PM +0800, Chen Liqin wrote:
> 
> Signed-off-by: Chen Liqin <liqin.chen@sunplusct.com>
> ---
>  arch/score/kernel/vmlinux.lds.S |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/score/kernel/vmlinux.lds.S b/arch/score/kernel/vmlinux.lds.S
> index aab4703..eebcbaa 100644
> --- a/arch/score/kernel/vmlinux.lds.S
> +++ b/arch/score/kernel/vmlinux.lds.S
> @@ -24,6 +24,8 @@
>   */
>  
>  #include <asm-generic/vmlinux.lds.h>
> +#include <asm/thread_info.h>
> +#include <asm/page.h>
>  
>  OUTPUT_ARCH(score)
>  ENTRY(_stext)

Hi Chen.

I assume this is needed to allow Tim's patchset to build.
The preferred way is that you integrate this into the original
patch and apply it to your tree.

We prefer arch specific patches to go in via the arch trees.

I sometime takes patches in via kbuild that touches a lot
of architectures but stuff like like should go in
via you.

For score (and for other archs) I cannot even build test stuff..

	Sam

      reply	other threads:[~2009-09-22  7:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22  6:32 [PATCH 1/2] score: add head files define in vmlinux.lds.S Chen Liqin
2009-09-22  7:37 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090922073718.GA29384@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liqin.chen@sunplusct.com \
    --cc=liqin.gnu@gmail.com \
    --cc=tabbott@ksplice.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).