From: Arnd Bergmann <arnd@arndb.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] sysctl: Separate the binary sysctl logic into it's own file.
Date: Fri, 6 Nov 2009 14:11:19 +0100 [thread overview]
Message-ID: <200911061411.19580.arnd@arndb.de> (raw)
In-Reply-To: <m1ljij24p0.fsf@fess.ebiederm.org>
On Friday 06 November 2009, Eric W. Biederman wrote:
> The primary proc path already doesn't need the lock_kernel(). My next
> patch winds up killing the entire binary path and rebuilding on top of
> /proc/sys. Which removes that lock_kernel().
>
> Which I think elegantly solves all of the sysctl BKL lock issues.
Yes, that sounds like an excellent plan, but I'm not completely sure
if the lack of the BKL in the procfs case is intentional. As a
particular case that I stumbled over, 'core_pattern' is read
with the BKL held to protect against sysctl changing it, but
it is changed with proc_dostring without the BKL.
Most uses of intvec or string seem to be racy and probably need
a proper serialization method anyway.
Arnd <><
next prev parent reply other threads:[~2009-11-06 13:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 0:40 [PATCH 0/11] generic compat_sys_sysctl Eric W. Biederman
2009-11-06 0:41 ` [PATCH 01/11] sysctl: Separate the binary sysctl logic into it's own file Eric W. Biederman
2009-11-06 9:04 ` Christian Borntraeger
2009-11-06 11:33 ` Eric W. Biederman
2009-11-06 12:10 ` Arnd Bergmann
2009-11-06 12:55 ` Eric W. Biederman
2009-11-06 13:11 ` Arnd Bergmann [this message]
2009-11-06 13:58 ` Eric W. Biederman
2009-11-06 0:41 ` [PATCH 02/11] sysctl: Refactor the binary sysctl handling to remove duplicate code Eric W. Biederman
2009-11-06 0:41 ` [PATCH 03/11] sysctl: Introduce a generic compat sysctl sysctl Eric W. Biederman
2009-11-06 0:41 ` Eric W. Biederman
2009-11-06 0:41 ` [PATCH 04/11] sysctl: ia64 Use the compat_sys_sysctl Eric W. Biederman
2009-11-06 0:41 ` [PATCH 05/11] sysctl: mips " Eric W. Biederman
2009-11-06 0:41 ` Eric W. Biederman
2009-11-06 0:41 ` [PATCH 06/11] sysctl: parisc " Eric W. Biederman
2009-11-06 6:01 ` Kyle McMartin
2009-11-06 0:41 ` [PATCH 07/11] sysctl: s390 " Eric W. Biederman
2009-11-06 0:41 ` Eric W. Biederman
2009-11-06 9:12 ` Christian Borntraeger
2009-11-06 10:19 ` Eric W. Biederman
2009-11-06 9:23 ` Martin Schwidefsky
2009-11-06 9:23 ` Martin Schwidefsky
2009-11-06 0:41 ` [PATCH 08/11] sysctl: sparc " Eric W. Biederman
2009-11-06 0:41 ` Eric W. Biederman
2009-11-06 1:42 ` David Miller
2009-11-06 0:41 ` [PATCH 09/11] sysctl: x86 " Eric W. Biederman
2009-11-06 0:41 ` Eric W. Biederman
2009-11-06 0:56 ` H. Peter Anvin
2009-11-06 0:56 ` H. Peter Anvin
2009-11-06 1:15 ` Eric W. Biederman
2009-11-06 0:41 ` [PATCH 10/11] sysctl: Remove the cond_syscall entry for sys32_sysctl Eric W. Biederman
2009-11-06 0:41 ` [PATCH 11/11] sysctl: Make do_sysctl static Eric W. Biederman
2009-11-06 0:41 ` Eric W. Biederman
2009-11-06 0:48 ` [PATCH 0/11] generic compat_sys_sysctl Eric W. Biederman
2009-11-06 10:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911061411.19580.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=borntraeger@de.ibm.com \
--cc=ebiederm@xmission.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).