From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@ftp.linux.org.uk>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/19] untangling do_mremap(), part 1
Date: Mon, 7 Dec 2009 19:43:05 +0000 [thread overview]
Message-ID: <20091207194305.GJ14381@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.00.0912071134300.3560@localhost.localdomain>
On Mon, Dec 07, 2009 at 11:35:16AM -0800, Linus Torvalds wrote:
>
>
> On Mon, 7 Dec 2009, Al Viro wrote:
> >
> > Which David? ;-) All sparc-related bits seem to have been ACKed by
> > davem.
>
> That's the David I meant. I've seen the ack, but the acks weren't actually
> quoted in your latest series.
Hugh had just caught a lovely piece of idiocy in do_brk() patch; that
call of get_unmapped_area() in there should take MAP_FIXED, not
MAP_FIXED | flags. Harmless (we do get MAP_FIXED anyway and the only
other flag that gets looked at by methods is MAP_SHARED, which is
ignored when file is NULL), but definitely bogus.
I'll fix that before sending a pull request.
next prev parent reply other threads:[~2009-12-07 19:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 3:52 [PATCH 1/19] untangling do_mremap(), part 1 Al Viro
2009-12-07 17:17 ` Linus Torvalds
2009-12-07 18:44 ` Al Viro
2009-12-07 19:35 ` Linus Torvalds
2009-12-07 19:43 ` Al Viro [this message]
2009-12-12 19:31 ` Pavel Machek
2009-12-12 19:31 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207194305.GJ14381@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).