From: David Miller <davem@davemloft.net>
To: James.Bottomley@HansenPartnership.com
Cc: isloginov@gmail.com, jens.axboe@oracle.com, linux-arch@vger.kernel.org
Subject: Re: problems in commit 2d4dc890b5c8 (block: add helpers to run flush_dcache_page() against a bio and a request's pages)
Date: Thu, 10 Dec 2009 14:03:53 -0800 (PST) [thread overview]
Message-ID: <20091210.140353.219266447.davem@davemloft.net> (raw)
In-Reply-To: <1260482418.2457.208.camel@mulgrave.site>
From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: Thu, 10 Dec 2009 16:00:18 -0600
> On Fri, 2009-12-11 at 00:27 +0300, Ilya Loginov wrote:
>> On Thu, 10 Dec 2009 14:59:36 -0600
>> James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>>
>> > To fix mips, you just need a
>> > flush_kernel_dcache_page() in slram_read so that the alias is updated
>> > after the memcpy.
>>
>> I think you right. But! If we choose this way:
>>
>> First. We need to realize flush_kernel_dcache_page() for many
>> architectures. Am I right?
>
> Actually, I think only sparc and mips need it. It's only needed for an
> aliasing architecture. Next, it's only used for pio drivers, so if the
> platform never uses a pio driver, it can get away without having this
> (that's the sparc case, I think).
Sparc has PIO drivers, namely IDE, and we have special flushes inserted
into the IDE string PIO routines to handle that case.
next prev parent reply other threads:[~2009-12-10 22:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 22:39 problems in commit 2d4dc890b5c8 (block: add helpers to run flush_dcache_page() against a bio and a request's pages) James Bottomley
2009-12-09 22:45 ` Russell King
2009-12-09 22:56 ` James Bottomley
2009-12-09 23:03 ` Ilya Loginov
2009-12-09 23:11 ` James Bottomley
2009-12-09 23:36 ` Ilya Loginov
2009-12-09 23:47 ` James Bottomley
2009-12-10 0:06 ` Ilya Loginov
2009-12-10 0:19 ` James Bottomley
2009-12-10 4:40 ` Ilya Loginov
2009-12-10 17:07 ` James Bottomley
2009-12-10 17:48 ` Russell King
2009-12-10 17:59 ` James Bottomley
2009-12-10 18:06 ` Russell King
2009-12-10 18:20 ` James Bottomley
2009-12-10 19:05 ` Russell King
2009-12-10 20:29 ` James Bottomley
2009-12-10 20:39 ` Russell King
2009-12-10 19:42 ` Ilya Loginov
2009-12-10 19:43 ` Russell King
2009-12-10 19:48 ` Ilya Loginov
2009-12-10 19:46 ` Ilya Loginov
2009-12-10 20:28 ` James Bottomley
2009-12-10 20:41 ` Ilya Loginov
2009-12-10 20:48 ` Ilya Loginov
2009-12-10 20:59 ` James Bottomley
2009-12-10 21:27 ` Ilya Loginov
2009-12-10 21:43 ` Ilya Loginov
2009-12-10 22:00 ` James Bottomley
2009-12-10 22:03 ` David Miller [this message]
2009-12-10 22:33 ` Ilya Loginov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210.140353.219266447.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=isloginov@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).