From: Christoph Hellwig <hch@infradead.org>
To: tytso@mit.edu, Linus Torvalds <torvalds@linux-foundation.org>,
Kyle McMartin <kyle@mcmartin.ca>,
linux-parisc@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
James.Bottomley@suse.de, hch@infradead.org,
linux-arch@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [git patches] xfs and block fixes for virtually indexed arches
Date: Thu, 17 Dec 2009 12:10:25 -0500 [thread overview]
Message-ID: <20091217171025.GB10431@infradead.org> (raw)
In-Reply-To: <20091217163036.GE2123@thunk.org>
On Thu, Dec 17, 2009 at 11:30:36AM -0500, tytso@mit.edu wrote:
> That's because apparently the iSCSI and DMA blocks assume that they
> have Real Pages (tm) passed to block I/O requests, and apparently XFS
> ran into problems when sending vmalloc'ed pages. I don't know if this
> is a problem if we pass the bio layer addresses coming from the SLAB
> allocator, but oral tradition seems to indicate this is problematic,
> although no one has given me the full chapter and verse explanation
> about why this is so.
Actually at least iscsi now has a workaround for that by checking for
PageSlab. Back when we deal with the XFS issue that check was only
available with debug options enabled. I tried to sort it out by
agreeing with the block and iscsi folks that either
a) we need to send down refcountable pages
b) block drivers need to accept kmalloced pages
I could not get any afreement, and thus we stopped using the kmalloced
pages in XFS which was easy enough. A bit later people fixed iscsi,
but we still don't have formal rules about what is acceptable to the
block layer.
next prev parent reply other threads:[~2009-12-17 17:10 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091216043618.GB9104@hera.kernel.org>
2009-12-17 13:22 ` [git patches] xfs and block fixes for virtually indexed arches Kyle McMartin
2009-12-17 13:22 ` Kyle McMartin
2009-12-17 13:25 ` Christoph Hellwig
2009-12-17 16:16 ` Linus Torvalds
2009-12-17 16:30 ` tytso
2009-12-17 16:46 ` Linus Torvalds
2009-12-17 16:46 ` Linus Torvalds
2009-12-17 17:07 ` Christoph Hellwig
2009-12-17 17:07 ` Christoph Hellwig
2009-12-17 17:42 ` Linus Torvalds
2009-12-17 17:51 ` Christoph Hellwig
2009-12-17 17:51 ` Christoph Hellwig
2009-12-17 18:08 ` Russell King
2009-12-17 18:08 ` Russell King
2009-12-17 18:17 ` Linus Torvalds
2009-12-17 18:17 ` Linus Torvalds
2009-12-19 18:33 ` Ralf Baechle
2009-12-19 18:33 ` Ralf Baechle
2009-12-21 17:14 ` James Bottomley
2009-12-17 17:39 ` tytso
2009-12-17 17:39 ` tytso
2009-12-17 17:51 ` Linus Torvalds
2009-12-17 19:36 ` Jens Axboe
2009-12-17 19:36 ` Jens Axboe
2009-12-17 23:57 ` James Bottomley
2009-12-17 23:57 ` James Bottomley
2009-12-18 1:00 ` FUJITA Tomonori
2009-12-18 2:44 ` Dave Chinner
2009-12-18 2:44 ` Dave Chinner
2009-12-18 3:51 ` FUJITA Tomonori
2009-12-18 3:51 ` FUJITA Tomonori
2009-12-18 7:10 ` James Bottomley
2009-12-18 7:08 ` James Bottomley
2009-12-18 9:34 ` FUJITA Tomonori
2009-12-18 10:01 ` James Bottomley
2009-12-18 10:01 ` James Bottomley
2009-12-18 10:24 ` FUJITA Tomonori
2009-12-18 10:30 ` James Bottomley
2009-12-18 12:00 ` Dave Chinner
2009-12-18 12:00 ` Dave Chinner
2009-12-18 0:21 ` FUJITA Tomonori
2009-12-18 14:17 ` tytso
2009-12-18 14:17 ` tytso
2009-12-21 8:53 ` FUJITA Tomonori
2009-12-17 17:10 ` Christoph Hellwig [this message]
2009-12-17 17:33 ` tytso
2009-12-17 17:33 ` tytso
2009-12-17 17:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217171025.GB10431@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@suse.de \
--cc=jens.axboe@oracle.com \
--cc=kyle@mcmartin.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).