From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] irq: handle irq0 special only on x86 Date: Tue, 12 Jan 2010 16:59:29 +0100 Message-ID: <20100112155929.GA5615@pengutronix.de> References: <1260350401-9858-1-git-send-email-u.kleine-koenig@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:47250 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424Ab0ALP7e (ORCPT ); Tue, 12 Jan 2010 10:59:34 -0500 Content-Disposition: inline In-Reply-To: <1260350401-9858-1-git-send-email-u.kleine-koenig@pengutronix.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: x86@kernel.org, linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Hello, On Wed, Dec 09, 2009 at 10:20:01AM +0100, Uwe Kleine-K=F6nig wrote: > I just noticed this when digging in the irq handling. At least for a= rm > this doesn't make sense. Not sure if x86 is the only arch this test > is valid for, but probably it is. =2E.. so I added linux-arch@vger.kernel.org >=20 > Signed-off-by: Uwe Kleine-K=F6nig > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: H. Peter Anvin > --- > kernel/irq/spurious.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) >=20 > diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c > index 22b0a6e..4996b66 100644 > --- a/kernel/irq/spurious.c > +++ b/kernel/irq/spurious.c > @@ -199,8 +199,10 @@ try_misrouted_irq(unsigned int irq, struct irq_d= esc *desc, > if (irqfixup < 2) > return 0; > =20 > +#if defined(CONFIG_ARCH_X86) > if (!irq) > return 1; > +#endif > =20 > /* > * Since we don't get the descriptor lock, "action" can the feed-back I have got up to now wasn't helpfull. (Only some "irq0 i= s evil---no it's not" discussion.) So what do you think? I admit the #ifdef isn't nice, but if the semantic is OK I'm willing to rework it into something more pretty. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.= de/ |