From: Christoph Hellwig <hch@lst.de>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux@arm.linux.org.uk,
dhowells@redhat.com, ysato@users.sourceforge.jp,
tony.luck@intel.com, geert@linux-m68k.org, zippel@linux-m68k.org,
gerg@uclinux.org, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, jdike@addtoit.com, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 1/6] generic sys_old_select
Date: Tue, 2 Feb 2010 09:34:40 +0100 [thread overview]
Message-ID: <20100202083440.GB7552@lst.de> (raw)
In-Reply-To: <m24om0shpe.fsf@igel.home>
On Mon, Feb 01, 2010 at 11:40:29PM +0100, Andreas Schwab wrote:
> > Index: linux-2.6/fs/compat.c
> > ===================================================================
> > --- linux-2.6.orig/fs/compat.c 2010-01-12 14:08:16.202003005 +0100
> > +++ linux-2.6/fs/compat.c 2010-01-29 23:35:20.187003404 +0100
> > @@ -1795,6 +1795,24 @@ asmlinkage long compat_sys_select(int n,
> > return ret;
> > }
> >
> > +struct compat_sel_arg_struct {
> > + compat_ulong_t n;
> > + compat_ulong_t inp;
> > + compat_ulong_t outp;
> > + compat_ulong_t exp;
> > + compat_ulong_t tvp;
> > +};
>
> Shouldn't the last four be compat_uptr_t?
Strictly speaking yes, although it doesn't matter for the generated
code. The patch below makes it use the strictly correct type:
Index: linux-2.6/fs/compat.c
===================================================================
--- linux-2.6.orig/fs/compat.c 2010-02-02 09:20:16.207003623 +0100
+++ linux-2.6/fs/compat.c 2010-02-02 09:20:53.554012789 +0100
@@ -1797,10 +1797,10 @@ asmlinkage long compat_sys_select(int n,
struct compat_sel_arg_struct {
compat_ulong_t n;
- compat_ulong_t inp;
- compat_ulong_t outp;
- compat_ulong_t exp;
- compat_ulong_t tvp;
+ compat_uptr_t inp;
+ compat_uptr_t outp;
+ compat_uptr_t exp;
+ compat_uptr_t tvp;
};
asmlinkage long compat_sys_old_select(struct compat_sel_arg_struct __user *arg)
next prev parent reply other threads:[~2010-02-02 8:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 18:55 [PATCH 1/6] generic sys_old_select Christoph Hellwig
2010-02-01 21:58 ` H. Peter Anvin
2010-02-01 22:40 ` Andreas Schwab
2010-02-02 8:34 ` Christoph Hellwig [this message]
2010-02-01 23:37 ` Russell King
2010-02-01 23:37 ` Russell King
2010-02-02 1:03 ` Greg Ungerer
2010-02-02 8:55 ` Dave Young
2010-02-08 14:05 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202083440.GB7552@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=schwab@linux-m68k.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=ysato@users.sourceforge.jp \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).