linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: James Bottomley <James.Bottomley@suse.de>
Cc: linux-arch@vger.kernel.org, linux-parisc@vger.kernel.org,
	rmk@arm.linux.org.uk, lethal@linux-sh.org,
	torvalds@linux-foundation.org, hch@lst.de,
	James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCHv3 0/5] fix xfs by making I/O to vmap/vmalloc areas work
Date: Fri, 5 Feb 2010 17:06:40 +0100	[thread overview]
Message-ID: <20100205160640.GA24344@lst.de> (raw)
In-Reply-To: <1265385057-2575-1-git-send-email-James.Bottomley@suse.de>

On Fri, Feb 05, 2010 at 09:50:52AM -0600, James Bottomley wrote:
> From: James Bottomley <James.Bottomley@HansenPartnership.com>
> 
> This is essentially a small tidy up from the previous series.  I
> thought about the Ben H additions, but since power doesn't seem to
> need this, they seemed a bit moot (we can expand the API when an
> actual user comes along).
> 
> The patch series adds a flush/invalidate_kernel_vmap_range() API that
> drivers using vmap/vmalloc areas must use before sending tohse areas
> for I/O.  This makes it crystal clear that coherence on these areas is
> the responsibility of the driver alone.  Fortunately xfs is the only
> thing in the kernel actually doing I/O to vmap areas.
> 
> Sin ce xfs is completely broken on most VIPT architectures without
> this, I'd like to submit it as a bug fix for 2.6.33.  Unfortunately,
> we actually have some parisc xfs users whose data is curently at
> severe risk.

Agreed.  There's also a lot of ARM users popping up with this recently,
while others worked around it using local flushing hacks previously.

  parent reply	other threads:[~2010-02-05 16:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-05 15:50 [PATCHv3 0/5] fix xfs by making I/O to vmap/vmalloc areas work James Bottomley
2010-02-05 15:50 ` [PATCHv3 1/5] mm: add coherence API for DMA to vmalloc/vmap areas James Bottomley
2010-02-05 15:50   ` [PATCHv3 2/5] parisc: add mm " James Bottomley
2010-02-05 15:50     ` James Bottomley
2010-02-05 15:50     ` [PATCHv3 3/5] arm: " James Bottomley
2010-02-05 15:50       ` James Bottomley
2010-02-05 15:50       ` [PATCHv3 4/5] sh: " James Bottomley
2010-02-05 15:50         ` James Bottomley
2010-02-05 15:50         ` [PATCHv3 5/5] xfs: fix xfs to work with Virtually Indexed architectures James Bottomley
2010-02-05 16:06 ` Christoph Hellwig [this message]
2010-02-07  0:26   ` [PATCHv3 0/5] fix xfs by making I/O to vmap/vmalloc areas work Kyle McMartin
2010-02-07  0:26     ` Kyle McMartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100205160640.GA24344@lst.de \
    --to=hch@lst.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=James.Bottomley@suse.de \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).