From: Catalin Marinas <catalin.marinas@arm.com>
To: linux-arch@vger.kernel.org
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Russell King <rmk@arm.linux.org.uk>
Subject: [RFC PATCH v2 3/5] pio-mapping: Use the PIO mapping API in libata-sff.c
Date: Thu, 11 Feb 2010 17:55:27 +0000 [thread overview]
Message-ID: <20100211175527.7848.1017.stgit@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <20100211175417.7848.41807.stgit@pc1117.cambridge.arm.com>
This patch shows an example of PIO API usage for non-highmem pages. It
currently only modifies the !highmem case. While it is indicated to no
longer differentiate between these, there is a benefit for the !highmem
case to use the non-atomic kmap API.
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Russell King <rmk@arm.linux.org.uk>
---
drivers/ata/libata-sff.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 741065c..02a3be9 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -36,6 +36,7 @@
#include <linux/pci.h>
#include <linux/libata.h>
#include <linux/highmem.h>
+#include <linux/pio-mapping.h>
#include "libata.h"
@@ -888,9 +889,13 @@ static void ata_pio_sector(struct ata_queued_cmd *qc)
kunmap_atomic(buf, KM_IRQ0);
local_irq_restore(flags);
} else {
- buf = page_address(page);
+ enum dma_data_direction dir = do_write ?
+ DMA_TO_DEVICE : DMA_FROM_DEVICE;
+
+ buf = pio_kmap(page, dir);
ap->ops->sff_data_xfer(qc->dev, buf + offset, qc->sect_size,
do_write);
+ pio_kunmap(page, dir);
}
qc->curbytes += qc->sect_size;
next prev parent reply other threads:[~2010-02-11 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 17:55 [RFC PATCH v2 0/5] PIO drivers and cache coherency Catalin Marinas
2010-02-11 17:55 ` [RFC PATCH v2 1/5] pio-mapping: Add generic support for PIO mapping API Catalin Marinas
2010-02-11 17:55 ` [RFC PATCH v2 2/5] pio-mapping: Add ARM support for the " Catalin Marinas
2010-02-11 17:55 ` Catalin Marinas [this message]
2010-02-11 17:55 ` [RFC PATCH v2 4/5] pio-mapping: Use the PIO mapping API in the ISP1760 HCD driver Catalin Marinas
2010-02-11 17:55 ` [RFC PATCH v2 5/5] pio-mapping: Use the PIO mapping API in the MMCI PL18x driver Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100211175527.7848.1017.stgit@pc1117.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-arch@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).