From: Paul Mundt <lethal@linux-sh.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>,
vapier@gentoo.org, linux-parisc@vger.kernel.org,
roland@redhat.com, "David S. Miller" <davem@davemloft.net>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] parisc: fix tracing of signals
Date: Sat, 13 Feb 2010 20:03:03 +0900 [thread overview]
Message-ID: <20100213110302.GA18636@linux-sh.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1002120816100.7792@localhost.localdomain>
On Fri, Feb 12, 2010 at 08:21:33AM -0800, Linus Torvalds wrote:
> On Fri, 12 Feb 2010, Kyle McMartin wrote:
> > Mike Frysinger pointed out that calling tracehook_signal_handler with
> > stepping=0 missed testing the thread flags, resulting in not calling
> > ptrace_notify. Fix this by testing if we're single stepping or branch
> > stepping and setting the flag accordingly.
> >
> > Tested, seems to work.
>
> Hmm. All other architectures either pass in zero, or test TIF_SINGLESTEP.
>
> I guess TIF_BLOCKSTEP is a parisc addition, so now parisc matches x86 and
> power etc, but it still makes me wonder about all those other
> architectures that pass in zero.
>
> For the curious, that seems to be at least sparc and 64-bit (but not
> 32-bit) sh.
>
> David? Paul?
>
It's a legitimate bug on sh64. We support hardware single stepping there
but never tied in the thread flags when the code was merged with 32-bit,
so this behaviour has existed for some time. I'll fix it up and send out
patches as soon as I get a chance to test it.
prev parent reply other threads:[~2010-02-13 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100212155306.GI24051@bombadil.infradead.org>
2010-02-12 16:21 ` [PATCH] parisc: fix tracing of signals Linus Torvalds
2010-02-12 17:10 ` Kyle McMartin
2010-02-12 17:10 ` Kyle McMartin
2010-02-12 23:58 ` Mike Frysinger
2010-02-13 11:03 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100213110302.GA18636@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=davem@davemloft.net \
--cc=kyle@mcmartin.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).