From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: Re: [patch 0/2] Run interrupt handlers always with interrupts disabled Date: Fri, 26 Mar 2010 08:14:57 +0000 Message-ID: <20100326081457.GA23570@flint.arm.linux.org.uk> References: <20100326000325.917127328@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20100326000325.917127328@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner , Nicolas Pitre Cc: Linus Torvalds , LKML , linux-arch@vger.kernel.org, Andrew Morton , Ingo Molnar , Peter Zijlstra , Alan Cox , Andi Kleen , David Miller , Greg Kroah-Hartman , Arnaldo Carvalho de Melo List-Id: linux-arch.vger.kernel.org On Fri, Mar 26, 2010 at 12:06:44AM -0000, Thomas Gleixner wrote: > The following patch series removes the IRQF_DISABLED functionality > from the core interrupt code and runs all interrupt handlers with > interrupts disabled. As was covered in previous discussions, what about drivers such as SMC91x which take a long time to retrieve packets from the hardware? Always running handlers with IRQs disabled will kill things such as serial on these platforms. So based on your description, I have no option but to NAK this. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:56859 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752196Ab0CZIQK (ORCPT ); Fri, 26 Mar 2010 04:16:10 -0400 Date: Fri, 26 Mar 2010 08:14:57 +0000 From: Russell King Subject: Re: [patch 0/2] Run interrupt handlers always with interrupts disabled Message-ID: <20100326081457.GA23570@flint.arm.linux.org.uk> References: <20100326000325.917127328@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100326000325.917127328@linutronix.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner , Nicolas Pitre Cc: Linus Torvalds , LKML , linux-arch@vger.kernel.org, Andrew Morton , Ingo Molnar , Peter Zijlstra , Alan Cox , Andi Kleen , David Miller , Greg Kroah-Hartman , Arnaldo Carvalho de Melo Message-ID: <20100326081457.iYlos8gd0WcYCDZRtDw39vFixE6OAUqlwUl6h42hWUo@z> On Fri, Mar 26, 2010 at 12:06:44AM -0000, Thomas Gleixner wrote: > The following patch series removes the IRQF_DISABLED functionality > from the core interrupt code and runs all interrupt handlers with > interrupts disabled. As was covered in previous discussions, what about drivers such as SMC91x which take a long time to retrieve packets from the hardware? Always running handlers with IRQs disabled will kill things such as serial on these platforms. So based on your description, I have no option but to NAK this. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: