From: Ralf Baechle <ralf@linux-mips.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Howells <dhowells@redhat.com>,
mingo@elte.hu, tglx@linutronix.de, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] X86: Optimise fls(), ffs() and fls64()
Date: Fri, 26 Mar 2010 18:58:28 +0100 [thread overview]
Message-ID: <20100326175827.GD20055@linux-mips.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1003261042580.3721@i5.linux-foundation.org>
On Fri, Mar 26, 2010 at 10:45:05AM -0700, Linus Torvalds wrote:
> I went back and checked the old Intel 386 docs from -92 or something, and
> it was "undefined" in there too. So at least Intel seems to have been very
> consistent on this.
>
> That said, maybe all implementations actually do the "don't touch" thing.
>
> But I do have this memory of us doing this ten+ years ago, though, and
> having to check the ZF after all. Which is why I reacted to the patch in
> the first place and checked the documentation.
My trusty old 486 book [1] in the remarks about the BSF instruction:
"The documentation on the 80386 and 80486 states that op1 is undefined if
op2 is 0. In reality the 80386 will leave the value in op1 unchanged.
The first versions of the 80486 will change op1 to an undefined value.
Later version again will leave it unchanged."
[1] Die Intel Familie in German language, by Robert Hummel, 1992
next prev parent reply other threads:[~2010-03-26 17:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4BACCB4E.7010108@draigBrady.com>
2010-03-26 14:42 ` [PATCH 1/3] X86: Optimise fls(), ffs() and fls64() David Howells
2010-03-26 14:42 ` [PATCH 2/3] Adjust the comment on get_order() to describe the size==0 case David Howells
2010-03-26 14:42 ` [PATCH 3/3] Optimise get_order() David Howells
2010-03-26 14:42 ` David Howells
2010-03-26 17:23 ` [PATCH 1/3] X86: Optimise fls(), ffs() and fls64() Linus Torvalds
2010-03-26 17:37 ` Scott Lurndal
2010-03-26 17:42 ` Linus Torvalds
2010-04-06 13:57 ` Jamie Lokier
2010-04-06 14:40 ` Linus Torvalds
2010-03-26 17:42 ` David Howells
2010-03-26 17:45 ` Linus Torvalds
2010-03-26 17:58 ` Ralf Baechle [this message]
2010-03-26 18:03 ` Linus Torvalds
2010-03-26 18:16 ` Matthew Wilcox
2010-04-06 13:30 ` Matthew Wilcox
2010-04-14 11:49 ` David Howells
2010-04-14 14:30 ` Avi Kivity
2010-04-15 8:48 ` David Howells
2010-04-15 8:49 ` Avi Kivity
2010-04-15 11:41 ` Jamie Lokier
2010-03-26 17:52 ` Matthew Wilcox
2010-04-14 13:13 ` David Howells
2010-01-13 19:39 David Howells
2010-01-13 20:15 ` Geert Uytterhoeven
2010-01-13 21:59 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326175827.GD20055@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).