From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Lokier Subject: Re: start_kernel(): bug: interrupts were enabled early Date: Thu, 1 Apr 2010 10:41:11 +0100 Message-ID: <20100401094111.GB29433@shareable.org> References: <20100331210555.GA17715@flint.arm.linux.org.uk> <20100325194100.GA2364@debian> <20100331134048.da4e35a7.akpm@linux-foundation.org> <4BB3B4DB.7040904@kernel.org> <19680.1270076318@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail2.shareable.org ([80.68.89.115]:34508 "EHLO mail2.shareable.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209Ab0DAJmx (ORCPT ); Thu, 1 Apr 2010 05:42:53 -0400 Content-Disposition: inline In-Reply-To: <19680.1270076318@redhat.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: David Howells Cc: Russell King , Yinghai Lu , Andrew Morton , Rabin Vincent , lkml , hpa@zytor.com, penberg@cs.helsinki.fi, cl@linux-foundation.org, Benjamin Herrenschmidt , linux-arch@vger.kernel.org David Howells wrote: > Russell King wrote: > > We use the standard generic kernel implementation. Is x86 different? ;) > > The optimised fast paths used on x86 rwsems don't disable interrupts. Any reason not to use the same technique for all the archs - plus the trick used in arch/armkernel/entry-armv.S:__kuser_cmpxchg for those archs which don't have atomic instructions or ll/sc? If the problem here is _only_ semaphores, and the above might make semaphores faster anyway, perhaps it's a solution. -- Jamie