From: David Miller <davem@davemloft.net>
To: rostedt@goodmis.org
Cc: a.p.zijlstra@chello.nl, mingo@elte.hu, acme@redhat.com,
paulus@samba.org, efault@gmx.de, fweisbec@gmail.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 2/2] ftrace: Use local_irq_{save,restore}_nmi() in tracers.
Date: Tue, 06 Apr 2010 18:17:17 -0700 (PDT) [thread overview]
Message-ID: <20100406.181717.01368166.davem@davemloft.net> (raw)
In-Reply-To: <1270602850.19685.15604.camel@gandalf.stny.rr.com>
From: Steven Rostedt <rostedt@goodmis.org>
Date: Tue, 06 Apr 2010 21:14:10 -0400
> On Tue, 2010-04-06 at 16:40 -0700, David Miller wrote:
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>> ---
>> kernel/trace/ftrace.c | 4 ++--
>> kernel/trace/trace_functions.c | 8 ++++----
>> kernel/trace/trace_sched_wakeup.c | 4 ++--
>> kernel/trace/trace_stack.c | 4 ++--
>> 4 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
>> index d9062f5..41d4282 100644
>> --- a/kernel/trace/ftrace.c
>> +++ b/kernel/trace/ftrace.c
>> @@ -612,7 +612,7 @@ function_profile_call(unsigned long ip, unsigned long parent_ip)
>> if (!ftrace_profile_enabled)
>> return;
>>
>> - local_irq_save(flags);
>> + local_irq_save_nmi(flags);
>
> These are equivalent for non sparc archs, correct?
Yes.
> If so,
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
next prev parent reply other threads:[~2010-04-07 1:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 23:40 [PATCH 2/2] ftrace: Use local_irq_{save,restore}_nmi() in tracers David Miller
2010-04-07 1:14 ` Steven Rostedt
2010-04-07 1:14 ` Steven Rostedt
2010-04-07 1:17 ` David Miller [this message]
2010-04-07 1:17 ` David Miller
2010-04-07 10:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100406.181717.01368166.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).