From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/2] ftrace: Use local_irq_{save,restore}_nmi() in tracers. Date: Tue, 06 Apr 2010 18:17:17 -0700 (PDT) Message-ID: <20100406.181717.01368166.davem@davemloft.net> References: <20100406.164002.40105966.davem@davemloft.net> <1270602850.19685.15604.camel@gandalf.stny.rr.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1270602850.19685.15604.camel@gandalf.stny.rr.com> Sender: sparclinux-owner@vger.kernel.org To: rostedt@goodmis.org Cc: a.p.zijlstra@chello.nl, mingo@elte.hu, acme@redhat.com, paulus@samba.org, efault@gmx.de, fweisbec@gmail.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org From: Steven Rostedt Date: Tue, 06 Apr 2010 21:14:10 -0400 > On Tue, 2010-04-06 at 16:40 -0700, David Miller wrote: >> Signed-off-by: David S. Miller >> --- >> kernel/trace/ftrace.c | 4 ++-- >> kernel/trace/trace_functions.c | 8 ++++---- >> kernel/trace/trace_sched_wakeup.c | 4 ++-- >> kernel/trace/trace_stack.c | 4 ++-- >> 4 files changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c >> index d9062f5..41d4282 100644 >> --- a/kernel/trace/ftrace.c >> +++ b/kernel/trace/ftrace.c >> @@ -612,7 +612,7 @@ function_profile_call(unsigned long ip, unsigned long parent_ip) >> if (!ftrace_profile_enabled) >> return; >> >> - local_irq_save(flags); >> + local_irq_save_nmi(flags); > > These are equivalent for non sparc archs, correct? Yes. > If so, > > Acked-by: Steven Rostedt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:48812 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932370Ab0DGBRP (ORCPT ); Tue, 6 Apr 2010 21:17:15 -0400 Date: Tue, 06 Apr 2010 18:17:17 -0700 (PDT) Message-ID: <20100406.181717.01368166.davem@davemloft.net> Subject: Re: [PATCH 2/2] ftrace: Use local_irq_{save,restore}_nmi() in tracers. From: David Miller In-Reply-To: <1270602850.19685.15604.camel@gandalf.stny.rr.com> References: <20100406.164002.40105966.davem@davemloft.net> <1270602850.19685.15604.camel@gandalf.stny.rr.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: rostedt@goodmis.org Cc: a.p.zijlstra@chello.nl, mingo@elte.hu, acme@redhat.com, paulus@samba.org, efault@gmx.de, fweisbec@gmail.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org Message-ID: <20100407011717.t8WhhLaMPNRJsu0QGgYt6uFTMi75KkmlWmFgZgPeHqY@z> From: Steven Rostedt Date: Tue, 06 Apr 2010 21:14:10 -0400 > On Tue, 2010-04-06 at 16:40 -0700, David Miller wrote: >> Signed-off-by: David S. Miller >> --- >> kernel/trace/ftrace.c | 4 ++-- >> kernel/trace/trace_functions.c | 8 ++++---- >> kernel/trace/trace_sched_wakeup.c | 4 ++-- >> kernel/trace/trace_stack.c | 4 ++-- >> 4 files changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c >> index d9062f5..41d4282 100644 >> --- a/kernel/trace/ftrace.c >> +++ b/kernel/trace/ftrace.c >> @@ -612,7 +612,7 @@ function_profile_call(unsigned long ip, unsigned long parent_ip) >> if (!ftrace_profile_enabled) >> return; >> >> - local_irq_save(flags); >> + local_irq_save_nmi(flags); > > These are equivalent for non sparc archs, correct? Yes. > If so, > > Acked-by: Steven Rostedt