From: Russell King <rmk@arm.linux.org.uk>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: David VomLehn <dvomlehn@cisco.com>,
to@dvomlehn-lnx2.corp.sa.net,
"linux-arch@vger.kernel.org"@cisco.comlinux-arch@vger.kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
maint_arch@dvomlehn-lnx2.corp.sa.net
Subject: Re: [PATCH 1/23] Make register values available to panic notifiers
Date: Mon, 12 Apr 2010 13:24:33 +0100 [thread overview]
Message-ID: <20100412122433.GB28208@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20100412120330.GA2566@osiris.boeblingen.de.ibm.com>
On Mon, Apr 12, 2010 at 02:03:30PM +0200, Heiko Carstens wrote:
> Wouldn't it be much easier to implement panic with an illegal op and let
> the exception handler set up the pt regs structure instead? Just like some
> architectures do that already for warnings.
> Have a look at lib/bug.c and at various arch/<...>/include/asm/bug.h.
> BUG_FLAG_PANIC would do the trick.
You also have the problem that there are panic() statements before
exception vectors are setup.
Eg, using lmb, you might want to allocate a page for a L2 page table
so you can setup the exception vectors, but the lmb allocator has a
panic statement which will be used on failure to allocate a page.
The result is that you don't know why you didn't boot since there's no
diagnostics from the kernel.
At least with the current setup, merely (re)directing the kernel printk
output results in something you can read.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2010-04-12 12:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 6:06 [PATCH 1/23] Make register values available to panic notifiers David VomLehn
2010-04-12 6:06 ` David VomLehn
2010-04-12 6:24 ` Mike Frysinger
2010-04-12 11:16 ` David Howells
2010-04-14 20:41 ` David VomLehn
2010-04-14 20:42 ` David VomLehn
2010-04-14 23:52 ` David Howells
2010-04-14 23:58 ` David Miller
2010-04-12 12:03 ` Heiko Carstens
2010-04-12 12:24 ` Russell King [this message]
2010-04-12 12:24 ` Russell King
2010-04-14 20:47 ` David VomLehn
2010-04-12 12:20 ` David Howells
2010-04-12 12:27 ` Russell King
2010-04-12 13:35 ` Martin Schwidefsky
2010-04-14 21:09 ` David VomLehn
2010-04-14 21:00 ` David VomLehn
2010-04-12 12:45 ` David Howells
2010-04-14 21:04 ` David VomLehn
2010-04-15 2:54 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100412122433.GB28208@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc="linux-arch@vger.kernel.org"@cisco.comlinux-arch \
--cc=dvomlehn@cisco.com \
--cc=heiko.carstens@de.ibm.com \
--cc=to@dvomlehn-lnx2.corp.sa.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).